[1.0.0] Add an NIS schema / fix integer ordering performance.#208
Merged
ChadSikorra merged 2 commits intoJul 11, 2026
Conversation
…it's compared properly and not lexographically as a string. Not doing this causes a huge performance penalty, as we over-select entries otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current way that integers are compared in PDO happens lexicographically (as the underlying data is stored as strings for attribute => values). When someone uses a GTE / LTE filter, this over-selects, causing us to have to filter the result set via PHP. To fix this we need to determine if the attribute being compared is an integer / numeric. Then PDO can cast the value to an integer and compare it normally. This fixes directory scaling issues with range related filters. I also need a follow up to fix scaling issues with subsearch filters in general so we page through / cap as we go in PDO, since results can be inexact by nature.