WIP: Honeypot Feature#1001
Open
MarkusTheOrt wants to merge 7 commits into
Open
Conversation
MarkusTheOrt
marked this pull request as ready for review
April 25, 2026 22:14
FozzieHi
reviewed
Apr 28, 2026
| return; | ||
| } | ||
|
|
||
| const botMember = |
Owner
There was a problem hiding this comment.
I'd be tempted to make moderator optional instead of putting the bot down as a moderator, similar to how the other "Automatic" logs look with no author.
Contributor
Author
There was a problem hiding this comment.
I did change that now, but its not that easy a fix, because the ban function does some additional checks for permissions, so if you just pass a null for moderator and change the parameter type it won't work. I had to add an additional check for the channel id, and some more checks / null returns.
- Also ensure this doesn't break existing logic.
FozzieHi
reviewed
May 16, 2026
| deleteMessageSeconds?: number, | ||
| ): Promise<boolean> { | ||
| if ( | ||
| originChannel.id !== Constants.CHANNELS.HONEYPOT || |
Owner
There was a problem hiding this comment.
I'd rather check whether moderator is null instead of implicitly depending on the honeypot channel here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.