Introduce AbstractCascadesRule and split rule kinds into interfaces#4322
Open
RobertBrunel wants to merge 1 commit into
Open
Introduce AbstractCascadesRule and split rule kinds into interfaces#4322RobertBrunel wants to merge 1 commit into
AbstractCascadesRule and split rule kinds into interfaces#4322RobertBrunel wants to merge 1 commit into
Conversation
Convert `CascadesRule`, `ExplorationCascadesRule`, and `ImplementationCascadesRule` from abstract classes to interfaces, and add a new `AbstractCascadesRule` abstract base class implementing `CascadesRule`. Concrete rules now extend `AbstractCascadesRule` and implement the appropriate rule-kind interface. This opens the door to rules that satisfy more than one kind. The change is mechanical across the rule files. Type signatures that previously took `CascadesRule` and only carried concrete (i.e., `AbstractCascadesRule`-derived) instances are tightened to `AbstractCascadesRule`. Co-authored-by: Normen Seemann <nseemann@apple.com>
RobertBrunel
force-pushed
the
AbstractCascadesRule
branch
from
988df26 to
c82f08c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert
CascadesRule,ExplorationCascadesRule, andImplementationCascadesRulefrom abstract classes to interfaces, and add a newAbstractCascadesRuleabstract base class implementingCascadesRule. Concrete rules now extendAbstractCascadesRuleand implement the appropriate rule-kind interface. This opens the door to rules that satisfy more than one kind.The change is mechanical across the rule files. Type signatures that previously took
CascadesRuleand only carried concrete (i.e.,AbstractCascadesRule-derived) instances are tightened toAbstractCascadesRule.