Repository navigation
Critical-point study: wording fixes left over from #33's reviews - #44
Merged
Merged
Conversation
- Newman and Ziff's p_c = 0.59274621(13) is a Monte Carlo measurement, not an exact value: the README, critical/README.md and the tests' header say "exact or high-precision", and the two p_c checks print it as the reference value. - The Salas and Sokal entry also cites secs. 1 and 4.3 and Table 5, which hold the cumulant's definition and the free-exponent fit the tests quote. - The tests' section 1 header now covers the open-edge shift against Ziff and Newman's measured crossings and the random-number check. - The site's turbulence entry says where the cascade ends depends on the medium. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfgH6WcwTueUFZKb6fS2s2
ahrazzle
approved these changes
Oct 28, 2026
zero-aska
commented
Oct 28, 2026
zero-aska
left a comment
Contributor
Author
There was a problem hiding this comment.
This review of 02f9fe6 was written by agent instances that did not draft the branch. Two reviewers covered it: one checked sources and claims, the other checked tests, prose and the site. Each finding was then given to a refuter (blocking ones would have had two). The PR was merged as 5fa2448 at 05:21Z, after ahrazzle approved it, so the fixes below need a follow-up PR.
What was verified
- Newman and Ziff 2000 (arXiv cond-mat/0005264). p_c = 0.59274621 ± 0.00000013 is a Monte Carlo estimate (their R^(h)), not an exact value. "Negligible here" holds:
- the error is 0.06% of the p_c error bars and 1.4e-4 of the smallest p_c tolerance;
- in the most sensitive check it is 0.2% of the L = 256 shift, against a 10% tolerance.
- The Salas and Sokal pinpoint (arXiv cond-mat/9904038) matches the LaTeX. Sec. 1 has U = 1 - V4/3 and V4 = 1.1679229(47). Sec. 4.1 has Delta = 7/4. Sec. 4.3 has Delta = 2.01 ± 0.22 and B4 = -0.48 ± 0.23. Table 2 has V4(16) = 1.16586(38). Table 5 has 2.007 ± 0.223 and -0.477 ± 0.228.
- The pinpoint covers every place the repository uses the paper.
- The 1.0e-4 shift at tests/critical.mjs:142 recomputes. So does 1.28e-4 for Delta = 7/4.
- Test headers.
- The new section 1 header (tests/critical.mjs:73-74) lists exactly what lines 75-124 do, with no Monte Carlo.
- The header's "two checks" against Ziff and Newman's measurements are the section-1 crossings check and the section-7 p_0.5(32) check.
- Test output.
- Base and head output of tests/critical.mjs differ only in "exact" becoming "reference" on the two p_c lines (one near() call in the pool.wide loop) and in the runtime. Every value, tolerance, sigma and margin is byte-identical: 33 PASS, 0 FAIL.
node tests/run.mjspasses on Node 18, 20 and 22.- The CI runs test (18), (20) and (22) succeeded on 02f9fe6.
- Prose.
- In README.md:338 and :361, every value called "exact or high-precision" is one or the other. The largest deviation is 1.43 sigma (xi at T = 2.4), so "1.5 standard deviations" still holds.
- The new clause in index.html:238 matches README.md:32 word for word.
- Wrapping and site checks.
scripts/check_site.pyis clean, and so isgit diff --check.- Edited lines are within the wrap width. The only lines over 119 columns already existed on main.
- Word diffs of the rewrapped paragraphs contain only the intended edits, apart from the tests header (refuted item below).
- PR body. Its account of the four changed files matches the diff.
Blocking findings
None.
Non-blocking findings
- critical/README.md:109, :121, :28. The results table still calls Newman and Ziff's p_c "Exact". Both reviewers raised this; it is the same issue as finding 1 of #33's re-review, in places that review did not name.
- The "What it reproduces" table heads its reference column
| Check | Exact | Model |(:109) and lists p_c, 0.59275, under it (:121). - The opening paragraph (:9-10), edited by this PR, says the same table is compared with "an exact or high-precision value".
- The short answer (:28) still says "lands on or near the exact numbers", and its bullet quotes 0.592746 (Newman and Ziff 2000).
- No number is affected, and the wording dates from before #33.
- Fix: rename the column "Exact or high-precision" (or "Reference"). At :28 say "exact or high-precision numbers", to match README.md:338.
- The "What it reproduces" table heads its reference column
- critical/table.mjs:1, :19, :26, :89-91, :96-98. table.mjs still prints p_c as "exact". Both reviewers raised this. critical/README.md:4 names this script as the one that prints the study's numbers.
- It prints PERC.pc under "Exact values (infinite lattice)".
- The rows "p_c, L = 32/128", "p_c, L = 64/256" and "p(R = 1/2), L = 256" print "exact 0.59275, mean - exact ...".
- The header comment (:1) says "the exact values beside them".
- tests/critical.mjs now prints "reference" for the same two means, so the repository labels one comparison two ways.
- Fix: label p_c "reference" or "high-precision" in the heading and in the :98 printout. For example, give the p_c columns their own label, as near() now does.
- critical/README.md:9-10 and tests/critical.mjs:7, :147, :170-171. V4 is also a numerical result. Salas and Sokal's V4 = 1.1679229(47) is partly a Monte Carlo integration ("we performed a Monte Carlo integration using 10^9 measurements", sec. 2). Their Table 2 caption says "exact except for a numerical integration".
- The new parenthetical in critical/README.md names only Newman and Ziff's threshold as not exact, yet the measurement-trap cumulant on the same list is compared with 1 - V4/3.
- tests/critical.mjs:7 groups V4 under "exact", and both Binder checks print "exact 0.6107".
- The error in U is 1.6e-6, against tolerances of 0.0035 to 0.005, so no result changes.
- Fix: write "(Newman and Ziff's measured threshold and Salas and Sokal's V4, whose errors are negligible here)", and pass 'reference' to the two Binder near() calls.
- index.html:238. The turbulence clause does not fully fix #33's review finding 2. The entry still names only "the size where viscosity takes over".
- The added "where the cascade ends depends on the medium" still reads as true if viscosity is the only cutoff, because the viscous size itself varies between media.
- In README.md:32-36 the same phrase is followed by the solar-wind ion scales and the sonic scale in molecular clouds, which settle it. The site entry has no such examples.
- Fix: use the review's "what ends the range depends on the medium", or add a short example (for example, "ions in the solar wind").
- PR body, "Checked", bullet 3. "No open PR touches these files." is false. Open PRs #12, #26, #35 and #37 change README.md, and all their heads predate #44.
- PR body, "Checked", bullet 4. The promised independent review did not happen before merge. The bullet says such a review "will follow before merge".
- The PR was opened at 05:17:59Z. ahrazzle approved it at 05:20:39Z and merged it at 05:21:21Z.
- Fix: put items 1-4 in a follow-up PR.
Refuted:
- tests/critical.mjs:7-8, dropped words. The rewrap of the header dropped three words ("it is", "those", "The"). These are copyedits inside the one sentence the PR openly rewrites. Lines 4-6 still say which two checks use Ziff and Newman's measurements, and the count is still right.
Verdict: merge
Generated by Claude Code
zero-aska
added a commit
that referenced
this pull request
Oct 28, 2026
Critical-point study: finish the exact/high-precision relabelling from #44's review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #33. It makes the four wording fixes that #33's reviews left as non-blocking:
No number, tolerance or check changes.
Changes
README.md(two places),critical/README.md's opening paragraph and the header oftests/critical.mjsnow say "exact or high-precision".reference, where they used to printexact.near()already took alabelargument.index.html#studies) now adds that where the cascade ends depends on the medium, as the root README andturbulence/README.mdsay.Edited paragraphs are rewrapped only as far as the change reaches. To keep the tests' header rewrap from reaching further lines, four words were also dropped ("it is", "those", "The"). The meaning is unchanged.
Checked
node tests/run.mjspasses all 8 check files on Node 18.20.8, 20.20.0 and 22.22.0.python3 scripts/check_site.pyis clean.README.md, and Critical-point study: wording fixes left over from #33's reviews #44 adds no conflict for any of them.Corrections after merge
critical/table.mjsstill called p_c exact, Salas and Sokal's V4 is high-precision too, and the turbulence entry still implied viscosity always ends the cascade. Critical-point study: finish the exact/high-precision relabelling from #44's review #45 makes those changes.🤖 Generated with Claude Code
https://claude.ai/code/session_01XfgH6WcwTueUFZKb6fS2s2