Skip to content

refactor: used shared cypress config - #1634

Merged
ext merged 1 commit into
mainfrom
refactor/shared-cypress
Sep 8, 2026
Merged

refactor: used shared cypress config#1634
ext merged 1 commit into
mainfrom
refactor/shared-cypress

Conversation

@ext

@ext ext commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown

CHANGELOG

Based on commits in this Pull Request this will create a patch release and the following entries will be added to the changelog:

Code Refactoring

  • used shared cypress config (refs SFKUI-6500) 0a3e101

If this is not correct you can amend the commit message(s).

Read more about the release process (swedish).

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Artifact sizes

No artifact size changes in this build.

@github-actions

github-actions Bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Förhandsgranskning 🐛 🔍

Dokumentation och exampel applikationer finns att förhandsgranska på:

Sida URL
Dokumentation https://Forsakringskassan.github.io/designsystem/pr-preview/pr-1634/
Vue Sandbox https://Forsakringskassan.github.io/designsystem/pr-preview/pr-1634/vue-sandbox
Applikationsmall https://Forsakringskassan.github.io/designsystem/pr-preview/pr-1634/examples/page-layout

Exempel för testning:

Sida URL
Tabell https://Forsakringskassan.github.io/designsystem/pr-preview/pr-1634/examples/table
Senast uppdaterad 2026-09-08 11:49 UTC i gh-pages.

ext
ext commented Sep 2, 2026
View reviewed changes
Comment thread cypress.config.ts
rules: {
/* some examples show how to use custom heading levels which often
* doesn't match the heading outline for the documentation */
"heading-level": ["off"],

@ext ext Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vill vi pusha på den här regeln på alla repon eller ska vi ta bor den från det gemensamma så de måste göra rätt från början?

Det kan bli problem med komponenter som innehåller hårdkodade rubriker men borde de inte slottas in eller en prop med rubriksnivå?

@dvitamin dvitamin Sep 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jo, hmm, om en komposit skulle använda en FKUI-komponent som har custom så kanske regeln ska vara fortsatt av ändå. Kluven.

Comment thread cypress.config.ts
"prefer-native-element": [
"error",
{
exclude: ["progressbar"],

@ext ext Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det här vore snyggare om @fkui/vue kunde leverera egentligen. Det är ju trots allt en vue-komponent som kan förändras över tid.

@ext
ext force-pushed the refactor/shared-cypress branch 2 times, most recently from 8cf6086 to b2ba1e7 Compare September 2, 2026 09:27
@ext
ext force-pushed the refactor/shared-cypress branch from b2ba1e7 to 9329cce Compare September 3, 2026 06:24
@ext
ext force-pushed the refactor/shared-cypress branch 2 times, most recently from 6f4b2e7 to 6124c29 Compare September 3, 2026 15:26
@ext

ext commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 1eafb81b-0ba0-43c9-aa0d-b6922451b666

📥 Commits

Reviewing files that changed from the base of the PR and between 3f7a49d and 6124c29.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • cypress.config.ts
  • cypress/support/common.ts
  • cypress/support/component-index.html
  • package.json
💤 Files with no reviewable changes (1)
  • cypress/support/component-index.html

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Cypress configuration now uses @forsakringskassan/cypress-config for documentation generation and HTML validation. Plugin installation is asynchronous for E2E and component testing. Cypress support code enables HTML validation through configure. The custom reporter and video settings were removed. The mocha-multi-reporters dependency was removed, and the shared Cypress configuration dependency was added. The component support HTML file was deleted.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 6124c

This change consolidates Cypress configuration and enables shared HTML validation support. No current merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided, so the change cannot be assessed from the author-provided description. Add a concise description that explains the migration to the shared Cypress configuration and the related dependency and setup changes.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: refactoring the Cypress setup to use a shared configuration.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/shared-cypress

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ext
ext force-pushed the refactor/shared-cypress branch from 6124c29 to 57a1534 Compare September 3, 2026 22:02
@ext
ext force-pushed the refactor/shared-cypress branch from 57a1534 to 0a3e101 Compare September 8, 2026 11:45
@ext
ext merged commit 465ed3d into main Sep 8, 2026
30 checks passed
@ext
ext deleted the refactor/shared-cypress branch September 8, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dvitamin dvitamin dvitamin approved these changes
@MCFK MCFK MCFK approved these changes
@NicklasWei NicklasWei Awaiting requested review from NicklasWei NicklasWei is a code owner
@udenius udenius Awaiting requested review from udenius udenius is a code owner
@jensviklander jensviklander Awaiting requested review from jensviklander jensviklander is a code owner
@emmeliv emmeliv Awaiting requested review from emmeliv emmeliv is a code owner
@irosvall irosvall Awaiting requested review from irosvall irosvall is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ext @dvitamin @MCFK