Add sketch menu drawing and transform tools - #74
Open
WC3D wants to merge 3 commits into
Open
Conversation
Expand the sketch toolbar with new geometry and editing commands: Draw tools: center-point circle, two-point circle, corner/center rectangle, inscribed/circumscribed/edge polygon with a side-count stepper, and placed sketch text. Create / Transform: offset paths, mirror across an axis or selected segment, and rectangular/circular patterns driven by a small options panel. Inspect: dimension tool with driving length dimensions, reference distance dimensions between point/midpoint/intersection anchors, and horizontal/vertical/fixed constraints with a lightweight solver. Supporting changes: planar region detection so extrudes can target overlapping profiles (with region-aware OCCT extrude + healing), geometry libs for the new tools, .skf persistence for constraints/ dimensions/texts, and unit plus real-kernel e2e tests.
A CSS extraction pass dropped 33 rules for classes that existed upstream but were restyled by the sketch menu work: selectable extrusion regions, sketch points (incl. fixed state), constrained segments, segment dimension labels, drag/curve handles, measurement points, polygon side stepper, constraint inspector, image resize handle, grid settings, and toolbar disabled states. Without them, selected extrusion profiles gave no visual feedback.
The closed-profile hit-target overlay sat above the region fill layer in the sketch SVG, so with Select active every click inside a profile started a whole-shape drag instead of toggling that region's extrusion selection. Region fills now receive clicks as intended; whole-shape dragging still works via marquee selection and selected-shape handles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new geometry and editing commands to the sketch toolbar:
Also includes region selection so overlapping and nested profiles (sketches within sketch) can be individually selected, modified, and unselected before extruding. Adds
.skfpersistence for the new sketch entities, plus unit and real-kernel e2e coverage.Follow-ups: #76 (extrusion hole-assignment fix) and #75 (Project + Sweep tools) stack on top of this branch.
Scope is intentionally limited to the sketch menu; construction-plane shapes will follow separately.