Refactor: Remove flake8 config and consolidate test fixtures#64
Merged
Conversation
- Remove dead [tool.flake8] from pyproject.toml; flake8 6.x reads .flake8 natively, not pyproject.toml without the flake8-pyproject plugin - Deduplicate m3_spec pytest fixture: move to tests/conftest.py, remove local copies and now-unused Path/load_spec imports from test_m3_bootstrap.py and test_orchestrator_m3.py - Move COMPOSE_BRAINSTORM.md to docs/compose-brainstorm.md and update reference in compose/README.md - Replace bare comment in netengine/workers/__init__.py with a module docstring Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011ximaGNAUMBmWyymkYstdX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates test fixtures and removes flake8 configuration, improving code organization and reducing duplication across the test suite.
Key Changes
pyproject.toml- the extensive exclusion list is no longer neededm3_specfixture from multiple test files intotests/conftest.pyto eliminate duplication and improve maintainabilityPath,load_spec) fromtest_m3_bootstrap.pyandtest_orchestrator_m3.pyafter fixture consolidationcompose/README.mdfromCOMPOSE_BRAINSTORM.mdtodocs/compose-brainstorm.md(with file rename)netengine/workers/__init__.pyto use proper docstring formatImplementation Details
The
m3_specfixture was previously defined in bothtest_m3_bootstrap.pyandtest_orchestrator_m3.pywith identical implementations. Moving it to the sharedconftest.pyfollows pytest best practices and makes it available to all tests that need it, reducing code duplication and improving maintainability.https://claude.ai/code/session_011ximaGNAUMBmWyymkYstdX