Implement org app deployment layer#161
Merged
aidankhogg merged 1 commit intoJun 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
AppCatalog,AppCatalogEntry,AppOIDCSettings,AppDNSSettings) to represent image, ports, env, volumes, healthcheck path, OIDC and DNS behavior and load spec-provided entries.AppHandler.deploy_appto derive deployment behavior from the catalog, persist status transitions (deploying,deployed,failed) and failure details via_persist_deployment, and record issued certificate metadata via_record_certificate.start_container(via_prepare_cert_mount) before starting the container instead of copying into a running container.AppHandler:update_app,restart_app,teardown_app, andhealthcheck_app, and an improved_start_app_containerthat composes volumes/env/ports/healthcheck.OrgAppsPhaseHandler.execute()by derivingkeycloak_url,admin_username, andadmin_passwordfromcontext.runtime_stateandspec.identity_inworld, and wire theAppCataloginto the handler.tests/test_app_handler.pycovering catalog usage, deterministic cert mounting, DNS and OIDC failure handling, idempotent redeploy, phase identity wiring, and lifecycle helpers.Testing
ruff check netengine/handlers/app_handler.py tests/test_app_handler.pyand it passed.pytest -q tests/test_app_handler.py tests/test_m1_handlers.pyand all tests passed (new tests intests/test_app_handler.pyplus existingtests/test_m1_handlers.pyran successfully).Codex Task