feat(pki): DNSSEC online signing + KSK/ZSK rotation; promote PKI gates to experimental#121
Merged
Merged
Conversation
…s to experimental (WS-A) Wire DNSSEC end-to-end instead of only generating keys: - PKIHandler.setup_dnssec gains keys_host_dir so keys land in <zone_dir>/keys, visible to the running CoreDNS at /etc/coredns/keys, and records generated_at for rotation aging. - DNSHandler.enable_dnssec + _inject_dnssec_into_corefile inject a CoreDNS `dnssec` online-signing block into the zone stanza and reload CoreDNS (idempotent, pure-function injection). - Phase 3 generates keys into the CoreDNS keys dir and activates signing, recording dnssec_signing_active in pki_output. - PKICertRotationWorker rotates KSK/ZSK once past their configured lifetimes. Gate policy (per decision): promote pki.dnssec_enabled, crl_enabled, ocsp_enabled (and intermediate_ca) from unsupported/reserved to EXPERIMENTAL in feature_state.py + models metadata + support matrix, so they load with a warning instead of being rejected. Promotion to stable is gated on a green CI e2e run (no Docker available in this environment to validate live). Tests: unit coverage for the Corefile injection, enable_dnssec, keys_host_dir, and DNSSEC rotation aging; an e2e DNSKEY-serving smoke test (CI Docker, @slow); updated loader/CLI tests for the unsupported→experimental transition. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018NsdPH4dcsbTWeTFuTgswY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WS-A of the v1/production push: take PKI DNSSEC from "keys generated but inert" to end-to-end online signing, and move the PKI advanced-feature gates from
unsupported(rejected) toexperimental(load-with-warning).DNSSEC end-to-end
PKIHandler.setup_dnssecgains akeys_host_dirso KSK/ZSK keys land in<zone_dir>/keys, which the already-running CoreDNS sees at/etc/coredns/keys— no container restart. Recordsgenerated_atfor rotation aging.DNSHandler._inject_dnssec_into_corefile(pure, idempotent) +enable_dnssecadd a CoreDNSdnsseconline-signing block to the zone stanza and reload CoreDNS.dnssec_signing_activeinpki_output.PKICertRotationWorkerrotates KSK/ZSK once past their configured lifetimes.Gate promotion
pki.dnssec_enabled,crl_enabled,ocsp_enabled, andintermediate_ca_enabledmove toexperimentalinfeature_state.py+ model metadata + the support matrix. They now load with a warning instead of being rejected. Promotion tostableis intentionally gated on a green CI e2e run — the dev environment has no Docker, so live signed-zone validation runs only in CI.Testing
enable_dnssec,keys_host_dirbinding, and DNSSEC rotation aging.@e2e @slow): generates keys, activates signing, and asserts CoreDNS serves DNSKEY records for the signed zone.unsupported→experimentaltransition.black/isort/flake8/mypy --strict.🤖 Generated with Claude Code
Generated by Claude Code