fix(build): unbreak v0.48.0 release build — webui compile errors + PR-time guard#896
Merged
Merged
Conversation
…-time guard make build-release (which runs a full `next build` with TypeScript type-checking) failed on the v0.48.0 tag: - ContainerListView.tsx destructured props omitted onSecurityClick even though it's declared in the props interface, used in the JSX, and already passed in by ContainerTopology.tsx — a straight typo from #886. - PentestView.tsx called client.listPentestScanRuns(<limit>) as a bare number, but the method's first positional param is the optional containerName string, not limit — passing a number there is a type error, not just a lint nit. Fixed both call sites to listPentestScanRuns(undefined, <limit>). Neither was caught at PR time because no CI job builds the web UI at all — the exact same "only surfaces at release time" gap as #884's Windows cross-compile break, just for the web UI. Closes it the same way #885 did: add the real `next build` as a step in the already-required "Unit + default e2e" job, so a future TypeScript error fails the PR instead of the release tag.
hsinatfootprintai
added a commit
that referenced
this pull request
Jul 3, 2026
v0.48.0's release build never published (webui compile errors, #896). Stamps CHANGELOG ahead of the v0.48.1 tag, which supersedes it; v0.48.0 stays a dead tag rather than being retargeted. Co-authored-by: hsinhoyeh <yhh92u@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make build-release(which runs a fullnext buildwith TypeScript type-checking) failed on the v0.48.0 tag with two genuine compile errors from #886, neither caught at PR time because no CI job builds the web UI at all:ContainerListView.tsxdestructured props omittedonSecurityClickeven though it's declared in the props interface, used in the JSX, and already passed in byContainerTopology.tsx— a straight typo.PentestView.tsxcalledclient.listPentestScanRuns(<limit>)as a bare number, but the method's first positional param is the optionalcontainerNamestring, notlimit— fixed both call sites tolistPentestScanRuns(undefined, <limit>).This is the same failure class as #884 (Windows cross-compile only caught at release time) — closed the same way #885 did: added the real
next buildas a step in the already-required "Unit + default e2e" job.Test plan
npx tsc --noEmitcleannpm run build(full production build) succeeds🤖 Generated with Claude Code