Skip to content

Statically compile type test for instance of operator - #680

Merged
bwrrp merged 1 commit into
FontoXML:masterfrom
DrRataplan:fix/instance-of-namespaces
Dec 24, 2025
Merged

Statically compile type test for instance of operator#680
bwrrp merged 1 commit into
FontoXML:masterfrom
DrRataplan:fix/instance-of-namespaces

Conversation

@DrRataplan

Copy link
Copy Markdown
Contributor

Without that, the namespace part is never picked up

Fixes #679

Without that, the namespace part is never picked up
@bundlemon

bundlemon Bot commented Sep 1, 2025

Copy link
Copy Markdown

BundleMon

Files updated (2)
Status Path Size Limits
fontoxpath.js
78.61KB (-341B -0.42%) -
fontoxpath.esm.js
78.72KB (-346B -0.43%) -

Total files change -687B -0.42%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@DrRataplan

Copy link
Copy Markdown
Contributor Author

Looks like my access to FontoXPath is revoked again.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 91.576%. remained the same
when pulling 7573bdf on DrRataplan:fix/instance-of-namespaces
into d5ac004 on FontoXML:master.

@bwrrp bwrrp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subtle bug, nice catch!

@DrRataplan

DrRataplan commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

@bwrrp since my push access is revoked, could you get this merged? Just ran into this bug again...

@bwrrp
bwrrp merged commit 9fe4afc into FontoXML:master Dec 24, 2025
7 checks passed
@DrRataplan
DrRataplan deleted the fix/instance-of-namespaces branch February 4, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

instance of returns false if namespaces are in play

3 participants