Repository navigation
test: the internal-tool leak test removes its git repositories through the shared fixture - #1774
Merged
Merged
Conversation
…h the shared fixture The eight cases built a temporary git repository each and never removed it. Every repository is now recorded and removed at the end through removeDirWithRetries, the fixture the other git-building tests use since #1765 and #1768. Review point of #1773. Signed-off-by: Felipe Marzochi <fmarzochi@gmail.com>
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eight cases of tests/check-internal-tool-leak.test.js built a temporary git repository each and never removed it, the one git-building test the sweep of #1768 left out (review point on #1773). Every repository is now recorded and removed at the end through removeDirWithRetries from tests/fixtures/remove-dir.js. Test 8 of 8 locally, lint clean.
Summary by cubic
Stops the internal-tool leak test from leaving temporary git repositories behind after each run. Every repo the test builds is now recorded and removed through
removeDirWithRetriesfromtests/fixtures/remove-dir, matching what the other git-building tests already do.Written for commit 4d3229e. Summary will update on new commits.