Various fixes to integrate with IMP - #13
Open
benmwebb wants to merge 57 commits into
Open
Conversation
Header A cannot include header B which in turn includes header A. This will cause a compile failure when building with per-cpp compliation.
We need to inline this function otherwise linkage will fail with multiple definitions.
This feature doesn't work in Python 3.6 and we don't appear to use it in this example anyway.
This file was empty, and trips up the build of IMP's documentation.
Use a raw string to hold math, otherwise we have to double-escape, e.g. \\hat, since \hat includes \h which is an invalid escape.
We can't build the SWIG wrappers for IMP.bff if NumPy support is unavailable, so detect this at cmake time. Remove spurious dependency on IMP.em, which is already covered under required_modules.
IMP requires Python 3, so the 'future' features division and print_function are always available.
Replace each `SWIG_Python_AppendOutput` with `SWIG_AppendOutput`.
Arguably DecayCurve should be an Object, but that would break a lot of the existing API (e.g. methods like operator+ that return a new object). As written the class leaks memory.
Don't try to show plots interactively by default. This causes automated testing of the examples to hang.
Multiple test methods with the same name will not be run by Python.
Use IMP's existing cmake code to enable AVX if requested. This has the advantage that we can detect at runtime if the support is present, in both C++ and Python.
Have AVX-specific functions throw a "not implemented" exception if they are called when AVX is disabled, rather than just doing nothing.
This example uses several quite large density maps, which can use more memory than can be addressed on a 32-bit operating system, such as our 32-bit Windows builds. Skip trying to run the example on these systems.
This was incorrectly making the edge_computed vector zero size.
SWIG 4.5 no longer adds #defines to map some Python 2 API functions to Python 3 equivalents. In order to build with this SWIG version, use the correct Python 3 API instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR encompasses a bunch of minor fixes needed to make IMP.bff interoperate nicely with IMP itself, and to build and test correctly on the wider range of platforms and configurations we use in the Sali Lab. With these fixes I should be able to incorporate IMP.bff into the next stable IMP release: