Repository navigation
Conversation
…or at each chunk end
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
music://uri and failed with "Malformed URL". Cache hits are now limited to the bytes actually cached, and a cache read that outlives its span resolves the stream URL.ChunkStitchingDataSourceopens the next chunk inside the same read. Media3 has no data source that carries a read across ranged requests.Related issue
Closes #1417
Closes #1422
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest(4,389 tests, 0 failures)./gradlew :app:compileFossDebugKotlinand./gradlew ktlintCheckpass.Phone and emulator: 0 load errors over several songs (main logs one per chunk), a partly cached song plays past its cached part (main fails with "Malformed URL"), cold-start music links play the linked song, playback continues in the background and with the screen off, and auto-advance with the screen off stays gapless with no seek back.
Test device and Android version: POCO X6 Pro (HyperOS, Android 16); Android emulator (API 37)
Screenshots or recordings
Risk and compatibility
Player path: the music data source chain and session callbacks change, the player wiring does not. Offload is off by default, which may cost some battery on phones where it worked; it can be turned back on. New DataStore key
music_audio_offload_enabled. No Room schema changes.