Repository navigation
fix: keep Shorts out of Subscriptions when Subscription shorts is off - #1435
Merged
Merged
Conversation
… they are reels (#1393)
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/shorts/ID. The parser reads that link, so RSS rows are filed as Shorts or videos without a Shorts tab browse per channel. Entries without such a link still go through the existing Shorts tab lookup.LOCKUP_CONTENT_TYPE_SHORTlockups. They stay video lockups but are now marked as Shorts.Related issue
Closes #1393
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest(4,394 tests, 0 failures)./gradlew :app:compileFossDebugKotlinand./gradlew ktlintCheckpass.On the phone, with 261 subscribed channels: a full refresh made 0 Shorts tab lookups, and the cache went from 13 reels stored as videos to 0 (checked against each channel's RSS links).
Test device and Android version: POCO X6 Pro (HyperOS, Android 16); Android emulator (API 37)
Screenshots or recordings
Risk and compatibility
Network: one Shorts tab browse less per channel and refresh when its RSS entries carry links. If YouTube stops linking Shorts, entries have no verdict and the old lookup runs as before. No Room schema or preference changes.