Skip to content

fix: keep Shorts out of Subscriptions when Subscription shorts is off - #1435

Merged
A-EDev merged 5 commits into
mainfrom
fix/subscription-shorts-rss-link
Oct 25, 2026
Merged

A-EDev merged 5 commits into
mainfrom
fix/subscription-shorts-rss-link

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • YouTube's channel RSS now links every Short as /shorts/ID. The parser reads that link, so RSS rows are filed as Shorts or videos without a Shorts tab browse per channel. Entries without such a link still go through the existing Shorts tab lookup.
  • A link verdict outranks a stored one, and a refresh files every cached row it knows is a reel as a Short. Reels that earlier passes stored as videos are repaired; a Short is never turned back into a video.
  • Collaboration reels from a channel's Home tab arrive as LOCKUP_CONTENT_TYPE_SHORT lockups. They stay video lockups but are now marked as Shorts.
  • The background new-video check takes the reel verdict from the links too, so it no longer announces or seeds Shorts as videos when a Shorts lookup fails.

Related issue

Closes #1393

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug
  • ./gradlew :app:testGithubDebugUnitTest (4,394 tests, 0 failures)
  • I ran any additional flavor-specific build or test tasks affected by this change. ./gradlew :app:compileFossDebugKotlin and ./gradlew ktlintCheck pass.
  • I manually tested the affected behavior on an Android device or emulator.

On the phone, with 261 subscribed channels: a full refresh made 0 Shorts tab lookups, and the cache went from 13 reels stored as videos to 0 (checked against each channel's RSS links).

Test device and Android version: POCO X6 Pro (HyperOS, Android 16); Android emulator (API 37)

Screenshots or recordings

Risk and compatibility

Network: one Shorts tab browse less per channel and refresh when its RSS entries carry links. If YouTube stops linking Shorts, entries have no verdict and the old lookup runs as before. No Room schema or preference changes.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings October 24, 2026 16:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added documentation Improvements or additions to documentation extraction InnerTube / NewPipe extraction and networking labels Oct 24, 2026
@A-EDev
A-EDev merged commit 86eef75 into main Oct 25, 2026
9 checks passed
@A-EDev
A-EDev deleted the fix/subscription-shorts-rss-link branch October 25, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation extraction InnerTube / NewPipe extraction and networking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Shorts still appear in Subscriptions feed after disabling "Subscription shorts"

2 participants