Skip to content

fix: History crash after big imports, empty Shorts filter, upside-down fullscreen and Open in YouTube - #1433

Merged
A-EDev merged 4 commits into
mainfrom
fix/history-chunks-shorts-filter-rotation-youtube-app
Oct 24, 2026
Merged

A-EDev merged 4 commits into
mainfrom
fix/history-chunks-shorts-filter-rotation-youtube-app

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Related issue

Closes #1424
Closes #1425
Closes #1426
Closes #1420

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug
  • ./gradlew :app:testGithubDebugUnitTest (4382 tests, 0 failures)
  • I ran any additional flavor-specific build or test tasks affected by this change. (ktlintCheck, :app:compileFossDebugKotlin)
  • I manually tested the affected behavior on an Android device or emulator.

New tests: VideoLookupChunkingTest, HeldOrientationTest, and two Shorts filter cases in SearchPagingSourceTest (both fail against the previous paging code).

On the emulator: the Shorts filter for "minecraft" and "cats" fills the grid and pages until YouTube stops sending more; tapping a Short opens the Shorts player and swiping continues the queue. Open in YouTube on a failed video opens the YouTube app.

Test device and Android version: Resizable emulator, API 37

Screenshots or recordings

Risk and compatibility

No Room schema change (the IN query keeps its SQL, only the DAO method is split), no new strings, no new permissions or manifest entries, no extra network requests.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings October 24, 2026 10:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces labels Oct 24, 2026
@A-EDev
A-EDev merged commit cb50860 into main Oct 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

2 participants