Repository navigation
feat(player): keyboard shortcuts for tablets with a keyboard - #1409
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modifier.mediaKeyboardShortcutswith a pure key mapper, following the TV player's focus-target pattern. The volume key handling moved fromMainActivityintoPlayerHardwareControllerso the arrow keys share it.Related issue
Closes #1401
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest: 4371 tests, 0 failed./gradlew :app:compileFossDebugKotlin,./gradlew ktlintCheck,python3 .github/scripts/nightly_notes.py --checkTest device and Android version: Android emulator with a hardware keyboard (Resizable_Experimental, API 37). Every key in the expanded video player, fullscreen, the music player and Shorts; the mini players ignore keys; the sleep timer sheet pauses the shortcuts and they return when it closes; the Meta + / list shows the Player group.
Screenshots or recordings
Risk and compatibility
No preference, database, permission, network or background work changes. Nothing runs per frame: the shortcuts are key events only.
Without a hardware keyboard nothing changes. The player takes key focus only while a keyboard is attached, through a bare focus target that adds nothing for TalkBack.
The change does not introduce secrets, private data, or unexpected telemetry.
New user-facing text uses Android string resources.
Dependency and lockfile changes are intentional and limited to this PR.
Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
Breaking changes and upgrade steps are clearly documented.