Skip to content

fix(music): stop the music home crashing when two top artists share a channel - #1408

Merged
A-EDev merged 3 commits into
mainfrom
fix/music-home-duplicate-seed
Oct 22, 2026
Merged

A-EDev merged 3 commits into
mainfrom
fix/music-home-duplicate-seed

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The music home picks each top artist's channel once for the "Similar to" blocks. Top artists were grouped by artist name but seeded by channel, so names like "Artist" and "Artist & Guest" could both seed one channel and repeat the other_performances:<channel> LazyColumn key, which crashed on scroll.
  • The music home shelf builder also emits each seed's "Other performances" and "More from" shelves once, so a repeated seed can no longer crash the list.
  • The top-artist pick moved into SimilarToSections.topArtistSeeds, with unit tests for two names on one channel and for artists without a channel.

Related issue

Closes #1386

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug
  • ./gradlew :app:testGithubDebugUnitTest: 4367 tests, 0 failed
  • I ran any additional flavor-specific build or test tasks affected by this change: ./gradlew :app:compileFossDebugKotlin, ./gradlew ktlintCheck, python3 .github/scripts/nightly_notes.py --check
  • I manually tested the affected behavior on an Android device or emulator.

Test device and Android version:

Screenshots or recordings

Risk and compatibility

  • No preference, database, network or background work changes. When two top artists share a channel, the music home now shows one "Similar to" block for that channel and picks the next artist instead.

  • The change does not introduce secrets, private data, or unexpected telemetry.

  • New user-facing text uses Android string resources.

  • Dependency and lockfile changes are intentional and limited to this PR.

  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.

  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings October 22, 2026 16:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces labels Oct 22, 2026
@A-EDev
A-EDev merged commit 8cfdb66 into main Oct 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: IllegalArgumentException in r8-map-id-1bc472750d0e199a595b605d86e549f82277503ba3fa03b250bce4dde8ebce27:3

2 participants