Repository navigation
feat: speed and volume swipes on the music player's side columns - #1407
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
settings_segment_colourstring had a broken placeholder (%1$) that failedTranslationFormatStringsTest; it is now%1$s.ui/components/shared/.SpeedSwipeDragtakes the player calls as lambdas,PlayerHapticsreplaces the private silent haptics inVideoPlayerHost, and the HUD placement rule is shared by both players.Related issue
Closes #1403
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest(4,364 tests, 0 failures)./gradlew :app:compileFossDebugKotlin,./gradlew ktlintCheck,python3 .github/scripts/nightly_notes.py --check)Test device and Android version: POCO X6 Pro 5G (2311DRK48G), Android 16
Screenshots or recordings
Risk and compatibility
New preference key
music_side_swipes, default off. With it off the music player's gestures are unchanged.The side-swipe handler listens in the Initial pointer pass and consumes only after vertical touch slop, so taps, the seek bar and the cover's sideways swipe are untouched.
The Vibration setting now also silences the music player, which used to vibrate regardless.
No Room schema change.
The change does not introduce secrets, private data, or unexpected telemetry.
New user-facing text uses Android string resources.
Dependency and lockfile changes are intentional and limited to this PR.
Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
Breaking changes and upgrade steps are clearly documented.