Skip to content

fix: stop channel pages stacking up in the back stack, and name wrapped causes in crash reports - #1405

Merged
A-EDev merged 3 commits into
mainfrom
fix/saved-state-size-1338
Oct 22, 2026
Merged

A-EDev merged 3 commits into
mainfrom
fix/saved-state-size-1338

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Opening a channel, artist, album or linked page that is already in the back stack now returns to it instead of stacking another copy. Moving back and forth between two channels used to add about 4 KB of saved state per page, which can push the activity's saved state past Android's limit when the app stops ([Bug]: RuntimeException in PendingTransactionActions.java:146 #1338).
  • Crash reports name the wrapped cause in the issue title, so RuntimeException from Android's transaction code reads as TransactionTooLargeException.

Related issue

Closes #1338

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug
  • ./gradlew :app:testGithubDebugUnitTest (4,331 tests, 0 failures)
  • I ran any additional flavor-specific build or test tasks affected by this change. (./gradlew :app:compileFossDebugKotlin, ./gradlew ktlintCheck, python3 .github/scripts/nightly_notes.py --check)
  • I manually tested the affected behavior on an Android device or emulator.

Test device and Android version: POCO X6 Pro 5G (2311DRK48G), Android 16; Android emulator (API 37)

Measured on the emulator with a temporary saved-state probe: 30 alternating channel links grew the activity's saved state from 4.8 KB to 127 KB before this change and to 13 KB after it, with Back going channel B, channel A, Home.

Screenshots or recordings

Risk and compatibility

  • Navigation only: a page opened again is returned to, and the pages above it close, instead of being stacked again.

  • No Room schema change, no new preferences.

  • The change does not introduce secrets, private data, or unexpected telemetry.

  • New user-facing text uses Android string resources.

  • Dependency and lockfile changes are intentional and limited to this PR.

  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.

  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings October 22, 2026 12:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces labels Oct 22, 2026
@A-EDev
A-EDev merged commit 91adcbb into main Oct 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: RuntimeException in PendingTransactionActions.java:146

2 participants