Repository navigation
fix(startup): the splash follows the launcher icon - #1399
Merged
Merged
Conversation
- Add splash styles for Material Sky and Material Mint: one base per icon, tone variants override the background - Re-apply the remembered splash theme when the selected icon changes, not only when the tone changes - Test that every alias with its own art has a splash of its own on every tone
github-actions
Bot
added
documentation
Chiehx0220
added a commit
to Chiehx0220/Fathom
that referenced
this pull request
Oct 22, 2026
- Add splash styles for Material Sky and Material Mint: one base per icon, tone variants override the background - Re-apply the remembered splash theme when the selected icon changes, not only when the tone changes - Register the .IconExpressiveSegmented and .IconExpressiveMint entries again in the splash style map - Test that every alias with its own art has a splash of its own on every tone - Raise the fork-diff budget to 118 files, 1360 lines and 443 hunks until Flow-Tube#1399 is merged
Chiehx0220
added a commit
to Chiehx0220/Fathom
that referenced
this pull request
Oct 23, 2026
- Budget is now 115 files, 1311 lines and 438 hunks, as Flow-Tube#1399 is merged - Refresh FORK-DIFF.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The startup splash did not follow the launcher icon in two cases.
MainActivityre-applied it only when the tone (light, dark, black) changed, so the first launch after a switch still opened on the old icon's splash. It now also re-applies when the saved selection changes (AppIconController.selected, the existingPlayerPreferences.selectedAppIconflow).icon_bg_material_skyandicon_bg_material_mint), and six tone variants that only set the window background.SplashThemesTestchecks that every alias with its own art resolves to a splash of its own on every tone. Flow Red and Flow Light share the default, and Ghost on light keeps its fallback by design. Without thethemes.xmlandSplashThemes.ktchange it fails and lists Material Sky and Material Mint on all three tones..github/nightly-notes/2026-10-22-fix-splash-launcher-icon.md.Related issue
Closes #1398.
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest: 4328 tests, 0 failed./gradlew ktlintCheck,python3 .github/scripts/nightly_notes.py --checkTest device and Android version: Pixel 6, Android 16.
On the device, I switched the icon in Appearance, force-stopped the app and cold started it once, for Material Sky and Material Mint on the light, dark and black tones. Each time the splash showed the tinted circle with the red F on the matching window (white, dark gray, black), nothing clipped, from the first launch after the switch. Mint on the dark tone was re-checked on the final commit; the other five ran on an earlier build of the same change. Android 12 and earlier are unchanged, as
setSplashScreenThemeneeds Android 13.Risk and compatibility
No preference or database change, no permission, no network or background work.
MainActivitycollects one more DataStore flow that already exists.The splash theme is still remembered only on Android 13 and later.
The change does not introduce secrets, private data, or unexpected telemetry.
No new user-facing text.
No dependency changes.
No Room schema change.
No breaking changes.