Repository navigation
fix(startup): the splash follows the launcher icon - #1397
Closed
Chiehx0220 wants to merge 1 commit into
Closed
Chiehx0220 wants to merge 1 commit into
Chiehx0220 wants to merge 1 commit into
Conversation
- Add splash styles for the Material Sky and Material Mint icons on every tone - Re-apply the remembered splash theme when the icon is switched, not only when the tone changes - Rename ExpressiveSplash to AliasSplash, as it now holds more than the Expressive icons - Test that every alias with its own art has a splash of its own
Chiehx0220
marked this pull request as draft
October 22, 2026 06:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The startup splash did not follow the launcher icon in two cases.
MainActivityre-applied it only when the tone (light, dark, black) changed, so the first launch after a switch still opened on the old icon's splash. It now also re-applies when the saved selection changes (AppIconController.selected, the existingPlayerPreferences.selectedAppIconflow).icon_bg_material_sky,icon_bg_material_mint).ExpressiveSplashandExpressiveSplashesare renamedAliasSplashandAliasSplashes, as they now hold more than the Expressive icons.SplashThemesTestchecks that every alias with its own art resolves to a splash of its own on every tone (Flow Red and Flow Light share the default; Ghost on light keeps its fallback by design). Without thethemes.xmlandSplashThemes.ktchange it fails and lists Material Sky and Material Mint on all three tones..github/nightly-notes/2026-10-22-fix-splash-follows-launcher-icon.md.Related issue
None.
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest: 4328 tests, 0 failed./gradlew ktlintCheck,python3 .github/scripts/nightly_notes.py --checkTest device and Android version: Pixel 6, Android 16.
On the device: switched to Material Sky in Appearance, force-stopped the app and cold started once. The splash showed the sky-blue circle with the red F on the dark window, with nothing clipped. Not checked on the device: Material Mint, and the light and black tones. Android 12 and earlier are unchanged, as
setSplashScreenThemeneeds Android 13.I asked an AI assistant to help find the cause, write the change and run the tests and the device check.
Screenshots or recordings
I can attach the splash frame from the Pixel 6 if wanted.
Risk and compatibility
No preference or database change, no permission, no network or background work.
MainActivitycollects one more DataStore flow that was already there.The splash theme is still remembered only on Android 13 and later.
The change does not introduce secrets, private data, or unexpected telemetry.
No new user-facing text.
No dependency changes.
No Room schema change.
No breaking changes.