Skip to content

fix(music): search rows, filter chips, region blocks, Japanese romanization and PiP close - #1394

Merged
A-EDev merged 13 commits into
mainfrom
fix/music-search-region-romaji-pip
Oct 21, 2026
Merged

A-EDev merged 13 commits into
mainfrom
fix/music-search-region-romaji-pip

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Music search keeps songs, videos, artists, albums and playlists when YouTube sends a shorter result page without playlistItemData or play overlays.
  • Music search shows every filter YouTube Music offers for the query, in its order: adds Artists, Featured playlists, Podcasts, Episodes and Profiles. Episodes play like songs, podcasts open as a playlist, profiles open on their channel page.
  • Filtered results are read from any section, and a new query or filter cancels the previous request.
  • A song or video refused by country, rate limit or membership is no longer called removed: it shows its own message ("Not available in your region" and two new lines). Music playback stops after 3 songs in a row that cannot play here, or one full pass of the queue, instead of skipping forever.
  • On-device lyrics romanization detects Japanese per song and no longer shows Chinese readings for kanji; the lyrics menu says it is not available for Japanese. Romanized text gets a space before Latin words.
  • Closing the picture-in-picture window pauses the video and keeps it open, the same as leaving the app. Shorts still stop playing ([Bug]: When I close a Shorts PiP, the audio from the Shorts continues until the end #1152).

Related issue

Closes #1379
Closes #1378
Closes #1352
Closes #1349

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug
  • ./gradlew :app:testGithubDebugUnitTest (4,300 tests, 0 failures)
  • I ran any additional flavor-specific build or test tasks affected by this change. (:app:compileFossDebugKotlin, ktlintCheck, nightly_notes.py --check)
  • I manually tested the affected behavior on an Android device or emulator.

Test device and Android version: Xiaomi 2311DRK48G, Android 16 (API 36)

Screenshots or recordings

Risk and compatibility

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

The refusal check is shared by music and video playback, so a region-blocked video now shows the region error instead of being skipped as removed. The PiP change only replaces the body of the dismiss job in MainActivity; entering PiP, auto-enter and expanding back are unchanged.

Copilot AI balanced review requested due to automatic review settings October 21, 2026 21:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added documentation Improvements or additions to documentation player Video and audio playback ui Compose UI, theming, or Material 3 surfaces extraction InnerTube / NewPipe extraction and networking labels Oct 21, 2026
@A-EDev
A-EDev merged commit 3ca5aad into main Oct 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation extraction InnerTube / NewPipe extraction and networking player Video and audio playback ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

2 participants