Repository navigation
fix(music): search rows, filter chips, region blocks, Japanese romanization and PiP close - #1394
Merged
Merged
Conversation
…om removed videos
… that cannot play
…ed text from Latin words
…sts, podcasts, episodes and profiles
…replaces the default one
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Closed
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playlistItemDataor play overlays.Related issue
Closes #1379
Closes #1378
Closes #1352
Closes #1349
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest(4,300 tests, 0 failures):app:compileFossDebugKotlin,ktlintCheck,nightly_notes.py --check)Test device and Android version: Xiaomi 2311DRK48G, Android 16 (API 36)
Screenshots or recordings
Risk and compatibility
The refusal check is shared by music and video playback, so a region-blocked video now shows the region error instead of being skipped as removed. The PiP change only replaces the body of the dismiss job in
MainActivity; entering PiP, auto-enter and expanding back are unchanged.