Repository navigation
fix: Private Space launch crash and local cover retriever timeout - #1389
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setWidgetPreviewsthrowIllegalArgumentExceptionon the main thread at launch. The rejection is now caught and logged, and previews are retried on a later run.MediaStoreThumbnailFetcher) and Coil'sVideoFrameDecoderran with no concurrency bound, so dozens ofMediaMetadataRetrieverinstances could be live at once. Their release and finalizer share one native lock, which kept the finalizer daemon waiting past its 10 s watchdog. Both now run onPerformanceDispatcher.mediaRetriever(Dispatchers.IO.limitedParallelism(2)), the decoder through a smallMediaRetrieverDecoderFactorywrapper.Related issue
Closes #1357
Closes #1353
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTestAlso ran
./gradlew ktlintCheck,:app:compileGithubDebugKotlinand:app:compileFossDebugKotlin(all passed) andpython3 .github/scripts/nightly_notes.py --check(valid).On device:
GlanceAppWidgetManager.setWidgetPreviews120 ms later, which threw the same... is not a valid AppWidget providerexception as the report, so Glance passes it through to the call now wrapped.MediaStoreThumbnails.load, 22 fast flings over Local Media › Music (202 songs): main peaked at 19 concurrent loads (202 loads), this branch at 2 (193 loads). Covers and video thumbnails render the same.Test device and Android version: Xiaomi 2311DRK48G, Android 16 (HyperOS 3)
Screenshots or recordings
Risk and compatibility
No migrations, permissions or network changes. Local cover and video-frame loads are capped at two at a time; on the test device a fast scroll finished a comparable number of loads.