Repository navigation
fix: startup crash, player status bar, system equalizer, Shorts playlists and bot wall - #1381
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AudioSessionAnnouncerlistener opens each session when ExoPlayer reports it and makes the playing player the system equalizer's session. The panel is built at tap time with that session, and the loudness gain is applied once the session exists. Listeners only, player construction unchanged.Related issue
Closes #1354
Closes #1355
Closes #1358
Closes #1362
Closes #1373
Closes #1375
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest(4,276 tests, 0 failures)ktlintCheck,:app:compileFossDebugKotlin,python3 .github/scripts/nightly_notes.py --check)New JVM tests:
ReadSafeDataStoreTest,AudioSessionRegistryTest,AudioSessionAnnouncerTest,PlaylistWalkTest, plus new cases inVideoPlaylistPageTest,PlayabilityVerdictTestandVideoErrorMapperTest.On the device:
dumpsys activity broadcasts: MusicFX receives the video (MOVIE) and music (MUSIC) sessions with real ids, re-announced when each starts playing.dumpsys media.audio_flingerwith MusicFX switched on: Equalizer, Bass Boost and Virtualizer on Flow's playing music session; Flow's Loudness Enhancer on the video session.Test device and Android version: Xiaomi 2311DRK48G, Android 16 (API 36)
Screenshots or recordings
Risk and compatibility
DataStore stays on 1.1.x; the 1.1.1 to 1.1.7 diff of the storage code is only the first-read retry.
The system equalizer change adds player listeners in the video player, the music service and the Shorts pool; how players are built, owned and released is unchanged.
A Shorts-only playlist costs one extra browse request. A fully walled extraction costs one visitor fetch and one more pass of the client ladder, once per visitor.
No preference migrations; the visitor store gains one key for the network the visitor was minted on.
The change does not introduce secrets, private data, or unexpected telemetry.
New user-facing text uses Android string resources.
Dependency and lockfile changes are intentional and limited to this PR.
Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
Breaking changes and upgrade steps are clearly documented.