Repository navigation
ci: run checks, tests, lint and APK build as parallel jobs - #1372
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.ymlnow runs four jobs in parallel: Checks (Snowball, spotless), Unit tests (both flavors plus the androidTest compile), Lint, and Build APK. Publish nightly and Create Release wait for all four.--max-workers=1from fix(ci): limit concurrent Kotlin compilations #1011 is replaced by.github/ci-gradle.properties(2 workers, 4 GB Gradle and 6 GB Kotlin daemon heaps), copied into~/.gradleon each runner.githubNightlyandfossRelease; tags still buildgithubReleaseandfossRelease. Signing verification, the size report and the GitHub release uploads follow the event.ubuntu-24.04inbuild.ymlandcodeql.yml.maxParallelForks= half the cores).Related issue
Change type
Validation
./gradlew :app:assembleGithubDebug(not run; the CI variants below were built instead)./gradlew :app:testGithubDebugUnitTest :app:testFossDebugUnitTest :app:compileGithubDebugAndroidTestKotlin --build-cachewith the CI properties in a temporary Gradle home: passed (4,239 github and 4,196 foss tests, 0 failures)./gradlew :app:testGithubDebugUnitTest --reruntwice more (CI properties and local properties) to check the test forks: passed./gradlew :app:assembleGithubNightly :app:assembleFossReleasewith the CI properties: passed;app-foss-universal-release.apkis 28,914,313 bytesactionlintwith shellcheck on both workflows: clean apart from the SC2016 info thatmainalready has./gradlew spotlessCheck: passedTest device and Android version:
Screenshots or recordings
Risk and compatibility
The Protect Main ruleset requires only "Build APK". That job keeps its name, so PRs are not blocked, but "Checks", "Unit tests" and "Lint" have to be added to the ruleset to block merges on their failures.
Memory headroom on the 16 GB runner with two workers is only proven by this PR's own CI run.
Release asset names, the keystore guards, both certificate checks and the FOSS size budget are unchanged.
The change does not introduce secrets, private data, or unexpected telemetry.
New user-facing text uses Android string resources.
Dependency and lockfile changes are intentional and limited to this PR.
Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
Breaking changes and upgrade steps are clearly documented.