Repository navigation
feat(lyrics): lrc.red and Unison sources, one lyrics run per song, version-aware matching - #1370
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LyricsHelper(Hilt singleton) for the player, the music service and downloads. A song change runs the provider chain once, and the run stops when the song is skipped.MediaMetadata.durationMs.LyricsMatching).27.395and3:12.818are read correctly. Before, BetterLyrics lyrics were all timed at 0 and skipped as unsynced.Related issue
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest(680 test classes, all passing):app:compileFossDebugKotlin,ktlintCheck)Test device and Android version: POCO X6 Pro 5G, Android 16. Seven songs from a cold lyrics cache (studio, live, feat., Japanese, Arabic): one provider run per song change, lrc.red word sync for アイドル, a live track kept off the studio lyrics, BetterLyrics still answering after an uncached song, and the providers sheet with the new switches saving.
Screenshots or recordings
Risk and compatibility
New preference keys
lyrics_provider_enabled_lrcredandlyrics_provider_enabled_unison, both default on. No migration needed.Network: lrc.red and Unison are each one request only when the providers above them miss. The duplicate provider chain per song is gone.
No Room schema change.
The change does not introduce secrets, private data, or unexpected telemetry.
New user-facing text uses Android string resources.
Dependency and lockfile changes are intentional and limited to this PR.
Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
Breaking changes and upgrade steps are clearly documented.