Repository navigation
fix: resume after screen off, DeArrow frames, gapless songs, shuffle and repeat on the card - #1359
Merged
Merged
Conversation
…gs, shuffle and repeat on the card
…ng repeat and shuffle
…s thumbnail shows
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Closes #1337
Closes #1344
Closes #1345
Closes #1347
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTestRan the CI steps in order:
spotlessCheck,:app:testGithubDebugUnitTest :app:testFossDebugUnitTest(8,369 tests, 0 failures),:app:compileGithubDebugAndroidTestKotlin,:app:lintGithubNightly,:app:assembleGithubRelease :app:assembleGithubNightly :app:assembleFossRelease. All pass.On the device: paused video locked for 3 minutes resumes with no codec error; the media card shows shuffle and repeat, and card shuffle reorders the in-app queue; the next song starts where the previous one ended with no seek; video notification repeat cycles off, this video, off; media keys pause the video.
Test device and Android version: POCO X6 Pro (2311DRK48G), HyperOS, Android 16
Screenshots or recordings
Risk and compatibility
Playback: surface attach order, a single in-place re-prepare on video decoder errors, and the music shuffle path now run through ExoPlayer's shuffle flag with the manager doing the reorder. Shuffle state is still saved with the queue. Network: DeArrow lookups are cached for an hour (404 answers included) and capped at 4 at a time. New preference
dearrow_random_frame, default on.