Skip to content

fix(music): stream AAC on macOS once the equalizer or crossfade is in use - #200

Merged
A-EDev merged 2 commits into
mainfrom
fix/music-eq-macos
Oct 25, 2026
Merged

A-EDev merged 2 commits into
mainfrom
fix/music-eq-macos

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

Music player follow-up 1 of 4, from the owner's test of the 22-part stack. Stacked on feat/music-queue-rows (PR #199); review and merge in order.

  • On macOS, WebKit plays WebM/Opus through its own player, so WebAudio receives silence and the equalizer and crossfade changed nothing. Measured in the app with analysers: every bin was silent for itag 251, and itag 140 (AAC) carried the signal and the equalizer moved its levels.
  • Once the equalizer or crossfade is in use on macOS, songs and preloads resolve as AAC, and the song playing reloads once as AAC from where it is.
  • Gain is applied per element: a song WebAudio cannot hear (a downloaded Opus file) keeps volume and loudness on the element itself, and a crossfade only uses scheduled gains when both songs are routed.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test: 744 tests passed, 0 failed
  • pnpm build: passed
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: not run on this branch (no Rust changes); clean at the top of the stack
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: not run on this branch (no Rust changes); no new warnings at the top of the stack
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: not run on this branch (no Rust changes); 825 passed, 0 failed at the top of the stack
  • I smoke-tested the affected desktop behavior. macOS: analyser measurements before and after the equalizer, for itag 251 and itag 140. The reload of a song already playing when the equalizer turns on is covered by unit tests only.
  • OS/device: the owner tested a local build of the whole stack on macOS. The checks above ran on macOS 27 (Apple Silicon); Windows and Linux were not run, and the change only applies on macOS.

Screenshots or recordings

Risk and compatibility

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed (changelog entry in v0.1.0-beta3.txt).
  • Dependency and lockfile changes are intentional and limited to this PR. No dependency changes.
  • Breaking changes and upgrade steps are clearly documented. No breaking changes.

Copilot AI balanced review requested due to automatic review settings October 25, 2026 19:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@A-EDev
A-EDev force-pushed the fix/music-eq-macos branch from 2d85287 to 3cb62cb Compare October 25, 2026 19:36
@A-EDev
A-EDev changed the base branch from feat/music-queue-rows to main October 25, 2026 19:36
@A-EDev
A-EDev merged commit 2d38a76 into main Oct 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants