Skip to content

FIX: Selecting a History result does not bump the result until Home Page result list is refreshed again #4638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
01Dri wants to merge 2 commits into
base: dev
Choose a base branch
from
+6 −2
Open

FIX: Selecting a History result does not bump the result until Home Page result list is refreshed again #4638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e687857
fix: requery in results when query string is empty
Dridev01 Aug 31, 2026
fba17f1
Merge branch 'dev' into fix/issue-4379
01Dri Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Flow.Launcher/ViewModel/MainViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2385,19 +2385,23 @@ public async void Hide(bool reset = true)
switch (Settings.LastQueryMode)
{
case LastQueryMode.Empty:
await ChangeQueryTextAsync(string.Empty);
await ChangeQueryTextAsync(string.Empty, isReQuery: true);

@cubic-dev-ai cubic-dev-ai Bot Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: In LastQueryMode.Empty (the default), this forces a fresh query on every Hide whenever the query text is already empty, since ChangeQueryTextAsync hits its isReQuery branch for an unchanged empty string. That means every dismissal of the launcher — including dismissals that never result in a reopen, dismissals right after executing a result (line 610), and plugin reloads (line 334) — now runs a full background search. Consider scoping the re-query (e.g., only when reopening on Show, or only when a stale-result condition holds) instead of unconditionally re-querying on every close.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At Flow.Launcher/ViewModel/MainViewModel.cs, line 2388:

<comment>In LastQueryMode.Empty (the default), this forces a fresh query on every Hide whenever the query text is already empty, since ChangeQueryTextAsync hits its isReQuery branch for an unchanged empty string. That means every dismissal of the launcher — including dismissals that never result in a reopen, dismissals right after executing a result (line 610), and plugin reloads (line 334) — now runs a full background search. Consider scoping the re-query (e.g., only when reopening on Show, or only when a stale-result condition holds) instead of unconditionally re-querying on every close.</comment>

<file context>
@@ -2385,19 +2385,23 @@ public async void Hide(bool reset = true)
                 {
                     case LastQueryMode.Empty:
-                        await ChangeQueryTextAsync(string.Empty);
+                        await ChangeQueryTextAsync(string.Empty, isReQuery: true);
                         break;
                     case LastQueryMode.Preserved:
</file context>

break;
case LastQueryMode.Preserved:
case LastQueryMode.Selected:
LastQuerySelected = Settings.LastQueryMode == LastQueryMode.Preserved;
if (string.IsNullOrEmpty(QueryText))
{
await ChangeQueryTextAsync(string.Empty, isReQuery: true);
}
break;
case LastQueryMode.ActionKeywordPreserved:
case LastQueryMode.ActionKeywordSelected:
var newQuery = _lastQuery.ActionKeyword;

if (!string.IsNullOrEmpty(newQuery))
newQuery += " ";
await ChangeQueryTextAsync(newQuery);
await ChangeQueryTextAsync(newQuery, isReQuery: true);

if (Settings.LastQueryMode == LastQueryMode.ActionKeywordSelected)
LastQuerySelected = false;
Expand Down
Loading