Document SECURITY_TWO_FACTOR and related 2FA config settings#2340
Conversation
9cc4a93 to
28f80c2
Compare
Add configuration reference entries for two-factor authentication settings that were only covered in the installation guide. Link the new entries to a dedicated installation walkthrough anchor and reference only the PR in the changelog entry. Fixes FlexMeasures#1760 Signed-off-by: Sankalp Thakur <sankalphimself@gmail.com>
28f80c2 to
270e1f4
Compare
|
Thanks @sankalpsthakur, nice contribution — the new entries slot neatly into the Security section, and the defaults all check out against the code. A note on the two commits I pushed to your branch earlier today (I see you've since squashed them into yours, which works too):
One heads-up for future PRs re. DCO: if you set While reviewing, we also noticed that |
Documentation build overview
|
Description
SECURITY_TWO_FACTORindocumentation/configuration.rst(Security section)SECURITY_TOTP_SECRETSis required when 2FA is ondocumentation/changelog.rstLook & Feel
New entries under Security in the configuration docs (same style as
SECURITY_TOKEN_*/SECURITY_TOTP_SECRETS):SECURITY_TWO_FACTORSECURITY_TWO_FACTOR_ENABLED_METHODSSECURITY_TWO_FACTOR_ALWAYS_VALIDATESECURITY_TWO_FACTOR_LOGIN_VALIDITYSECURITY_TWO_FACTOR_RESCUE_MAILSECURITY_TOTP_ISSUERSECURITY_TOTP_SECRETSalready had a section; it now notes that it is required whenSECURITY_TWO_FACTORis enabled.How to test
Docs-only change. Spot-check the rendered Security section of the configuration docs, or:
Further Improvements
None planned.
Related Items
Fixes #1760
Sign-off