Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the file move functionality by ensuring that the underlying physical file is atomically moved on disk when a file is moved or replaced, not just its metadata. The changes introduce a new utility function for renaming (moving) files within the storage directory and update the move logic to use this function, improving data consistency and error handling during file operations.
File Move and Replacement Improvements:
renameFileutility, ensuring the storage reflects metadata changes and preventing inconsistencies. (move.ts,fileStorage.ts) [1] [2]File Storage Utility Enhancements:
renameFilefunction tofileStorage.tsthat securely renames (moves) a file within the storage directory, with proper error handling for missing files and failed operations. (fileStorage.ts)renameFilefunction fromfileStorage.tsfor use elsewhere in the codebase. (fileStorage.ts)Dependency Updates:
fileStorageutility in the file move controller to support the updated move logic. (move.ts)