feat(wpfx): add icon font cluster (IconAttribute, IconDescriptor, IconExtensions, IconDisplayer)#14
Merged
Merged
Conversation
…nExtensions, IconDisplayer) Port the pure-WPF icon-font helpers from the retired FlakEssentials.WpfEx into FEx.WPFx, where reusable WPF controls already live. They have no Telerik dependency and are used across the apps being migrated (SynoDesk, FlakApps.Wpf, FlakApps.Telerik.WinDesktop), so they belong in the framework, not a consumer. - FEx.WPFx.Attributes: IconAttribute, IconDescriptorAttribute - FEx.WPFx.Extensions: IconExtensions (GetIcon/GetIconCharacter/GetAltText) - FEx.WPFx.Controls: IconDisplayer (TextBlock-based)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Port the pure-WPF icon-font helpers from the retired
FlakEssentials.WpfExintoFEx.WPFx, where reusable WPF controls already live:IconAttribute,IconDescriptorAttributeIconExtensions(GetIcon/GetIconCharacter/GetAltText)IconDisplayer(TextBlock-based)Why
The cluster was the one part of
WpfExnot yet superseded byFEx.WPFx. It has no Telerik dependency (pure WPF +FEx.Agnostics.Abstractions) and is used across the apps being migrated onto current FEx (SynoDesk: 5 controls + MainWindow; FlakApps.Wpf; FlakApps.Telerik.WinDesktop; FlakEssentials.TelerikEx). It belongs in the framework, not a consumer. Surfaced while migrating the SynoDesk -> FEx.Legacy Telerik layer.Checks
dotnet build FEx.WPFxgreen (net481,TreatWarningsAsErrors=true).--swea): 0 ERROR.🤖 Generated with Claude Code