chore(frontend): keep jest and tsc out of storybook-static - #8443
chore(frontend): keep jest and tsc out of storybook-static#8443talissoncosta wants to merge 1 commit into
Conversation
A Storybook build copies the source into storybook-static, and neither jest nor tsc reads .gitignore, so both walk into it and work on a stale second copy of everything. Once the source moves on, that copy stops compiling and npm run typecheck and npm run test:unit fail locally for reasons that have nothing to do with your branch. CI checks out clean, so it never saw this. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
front-end
Docker builds report
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughJest now ignores tests in Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change prevents generated Storybook copies from causing duplicate test and typecheck failures without altering application runtime behavior. No actionable merge-blocking risk remains after normal checks and review. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ private-cloud · depot-ubuntu-latest-16 — run #20066 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
🗂️ Previous results✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20066 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
✅ oss · depot-ubuntu-latest-arm-16 — run #20066 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
✅ oss · depot-ubuntu-latest-16 — run #20066 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
|
Visual Regression19 screenshots compared. See report for details. |
1 participant
Changes
npm run build-storybookwrites a copy of the source intostorybook-static/. It is gitignored, but neither jest nor tsc reads gitignore, so both walk into it and pick up a stale second copy of every test and every file.Once the real source moves on, that copy stops compiling, and
npm run typecheckandnpm run test:unitstart failing locally on code you never touched. CI checks out clean, so it never saw it.How did you test this code?
Ran a Storybook build, confirmed
npm run test:unitandnpm run typecheckboth reported failures fromstorybook-static/, then applied this and confirmed both are clean with the directory still present.