fix: identify user before sending warehouse test event - #8356
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
Bot
added
the
front-end
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthrough
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🔵 Low · up to The warehouse test event now identifies a user before tracking, preventing events with null identifiers from being dropped. The remaining bounded risk is that the unit test does not enforce this call ordering, so the PR is mergeable with owner awareness and a follow-up test improvement. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Docker builds report
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 003afed4-4408-46ed-93cf-7bc63a764782
📒 Files selected for processing (2)
frontend/web/components/pages/environment-settings/tabs/warehouse-tab/__tests__/sendWarehouseTestEvent.test.tsfrontend/web/components/pages/environment-settings/tabs/warehouse-tab/sendWarehouseTestEvent.ts
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.
✅ private-cloud · depot-ubuntu-latest-16 — run #19735 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
🗂️ Previous results✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19735 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
✅ oss · depot-ubuntu-latest-arm-16 — run #19735 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
✅ oss · depot-ubuntu-latest-16 — run #19735 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19723 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
✅ private-cloud · depot-ubuntu-latest-16 — run #19723 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
✅ oss · depot-ubuntu-latest-16 — run #19723 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
✅ oss · depot-ubuntu-latest-arm-16 — run #19723 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
|
Visual Regression19 screenshots compared. See report for details. |
talissoncosta
left a comment
talissoncosta
left a comment
There was a problem hiding this comment.
Looks good to me! Just curious about the comment code rabbit raised.
2 participants
docs/if required so people know about the feature.Changes
The warehouse test event ("Send your first event" button) was sending events with
identifier: nullbecause the SDK instance never identified a user. The ingestion pipeline now requires an identifier, so the event was silently dropped.Added
instance.identify('test_warehouse_user')after init and beforetrackEvent, so the event payload includes a non-null identifier.How did you test this code?
Unit tests updated and passing (
npm run test:unit -- --testPathPatterns='sendWarehouseTestEvent'). Verified the identify call is made with'test_warehouse_user'before the event is tracked.