Skip to content

feat(github-poc): Submit feature flag code references - #5928

Merged
emyller merged 14 commits into
mainfrom
feat/submit-github-code-references
Aug 14, 2025
Merged

feat(github-poc): Submit feature flag code references#5928
emyller merged 14 commits into
mainfrom
feat/submit-github-code-references

Conversation

@emyller

@emyller emyller commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

Contributes to #5730.

This connects to #5731 and allows for CI to push code references found for a project's feature flags.

@emyller
emyller requested review from a team as code owners August 13, 2025 17:37
@emyller
emyller requested review from Zaimwa9 and removed request for a team August 13, 2025 17:37
@vercel

vercel Bot commented Aug 13, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs ⬜️ Ignored Preview Aug 14, 2025 4:13pm
flagsmith-frontend-preview ⬜️ Ignored Preview Aug 14, 2025 4:13pm
flagsmith-frontend-staging ⬜️ Ignored Preview Aug 14, 2025 4:13pm

@emyller emyller changed the title feat/submit-github-code-references feat(github-poc): Submit feature flag code references Aug 13, 2025
@github-actions github-actions Bot added the api Issue related to the REST API label Aug 13, 2025
@github-actions

github-actions Bot commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5928 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5928 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5928 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5928 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5928 Finished ✅ Results

@emyller
emyller marked this pull request as draft August 13, 2025 17:40
@emyller
emyller force-pushed the feat/submit-github-code-references branch from 83f4dd9 to 53f1763 Compare August 13, 2025 17:41
@github-actions github-actions Bot added the feature New feature or request label Aug 13, 2025
@emyller
emyller force-pushed the feat/submit-github-code-references branch from 53f1763 to 25c1fd3 Compare August 13, 2025 17:45
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 13, 2025
@emyller
emyller force-pushed the feat/submit-github-code-references branch from 25c1fd3 to d279391 Compare August 13, 2025 17:49
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 13, 2025
@codecov

codecov Bot commented Aug 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.85%. Comparing base (c533d95) to head (794f3ef).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5928      +/-   ##
==========================================
+ Coverage   97.83%   97.85%   +0.01%     
==========================================
  Files        1258     1269      +11     
  Lines       44630    44990     +360     
==========================================
+ Hits        43664    44024     +360     
  Misses        966      966              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emyller
emyller force-pushed the feat/submit-github-code-references branch from d279391 to 09b07ac Compare August 13, 2025 17:56
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 13, 2025
@emyller
emyller force-pushed the feat/submit-github-code-references branch from 09b07ac to 85e8495 Compare August 13, 2025 18:15
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 13, 2025
Comment thread api/projects/code_references/serializers.py

@khvn26 khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a couple of questions and comments.

Overall, I have been struggling to review this series of GitHub PoC PRs, as I feel that I do not have a clear idea of how this tool is going to be used. The lack of user-facing documentation (or at least a draft) and UI mockups is not helping.

@emyller

emyller commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

Overall, I have been struggling to review this series of GitHub PoC PRs, as I feel that I do not have a clear idea of how this tool is going to be used. The lack of user-facing documentation (or at least a draft) and UI mockups is not helping.

I agree this is lacking intel, I'm sorry. I've added mockups to the frontend issue. I hope it helps!

I've also created a draft PR for retrieving code references for a feature flag.

@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 14, 2025
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 14, 2025
@emyller
emyller marked this pull request as draft August 14, 2025 15:27
@emyller emyller self-assigned this Aug 14, 2025
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 14, 2025
@emyller
emyller force-pushed the feat/submit-github-code-references branch from c6e3aa1 to 327c9a0 Compare August 14, 2025 15:39
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 14, 2025
@emyller
emyller force-pushed the feat/submit-github-code-references branch from 327c9a0 to c5d2593 Compare August 14, 2025 15:44
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 14, 2025
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 14, 2025
@emyller
emyller marked this pull request as ready for review August 14, 2025 16:17
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 14, 2025

@khvn26 khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants