refactor: Refactor segment cloning - #5898
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Contributor
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5898 +/- ##
========================================
Coverage 97.83% 97.83%
========================================
Files 1259 1258 -1
Lines 44904 44630 -274
========================================
- Hits 43932 43664 -268
+ Misses 972 966 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emyller
force-pushed
the
refactor/segment-cloning
branch
from
August 6, 2025 23:22
3a11ead to
321d9aa
Compare
emyller
force-pushed
the
refactor/segment-cloning
branch
from
August 7, 2025 12:56
321d9aa to
1c140d5
Compare
matthewelwell
requested review from
a team and
Zaimwa9
and removed request for
a team and
matthewelwell
August 7, 2025 13:23
Zaimwa9
requested changes
Aug 8, 2025
Zaimwa9
left a comment
Zaimwa9
left a comment
Contributor
There was a problem hiding this comment.
Good job overall, too bad we didn't go this way earlier.
I have a couple of comments, mostly related to the order of setting version -> copying rules. The lifecycle related one is the most important to double check imo.
Zaimwa9
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #5771.
Warning
Blocked by #5769.
I have added information todocs/if required so people know about the feature!Changes
How did you test this code?
Note
The
segmentfixture was also creating a revision of the generated segment, for a reason I can't make peace with. That was removed. I'm sorry segment version numbers are shifted-1in tests, but things should be clearer now I hope.