fix: prevent unauthorised access from group permissions - #5893
Merged
matthewelwell merged 11 commits intoAug 20, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5893 +/- ##
=======================================
Coverage 97.82% 97.83%
=======================================
Files 1258 1260 +2
Lines 44846 44919 +73
=======================================
+ Hits 43872 43946 +74
+ Misses 974 973 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Docker builds report
|
matthewelwell
changed the title
gagantrivedi
approved these changes
Aug 19, 2025
matthewelwell
deleted the
origin/fix/prevent-unauthorised-access-from-group-permissions-v2
branch
August 20, 2025 08:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR prevents users that were part of groups in organisations that they no longer belong to from accessing the resources in that organisation.
From testing, the only way that this was possible in the first place was if the user was removed from the organisation in one of the following non-standard ways:
Note that this PR also includes a (tested) migration to remove any users from groups in organisations they do not belong to.
Also see #5865 for additional context (this PR was created to avoid git pain after rebase + squash)
How did you test this code?
Added a lot of new unit tests.