feat: phased rollout - #5890
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Zaimwa9
reviewed
Aug 5, 2025
gagantrivedi
force-pushed
the
feat/5675-phased-rollout
branch
2 times, most recently
from
August 6, 2025 03:19
6ed3028 to
6878dfc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5890 +/- ##
==========================================
+ Coverage 97.83% 97.84% +0.01%
==========================================
Files 1258 1261 +3
Lines 44630 44883 +253
==========================================
+ Hits 43664 43917 +253
Misses 966 966 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gagantrivedi
force-pushed
the
feat/5675-phased-rollout
branch
2 times, most recently
from
August 11, 2025 05:35
2b97bb9 to
7b1d747
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a phased rollout feature for release pipelines, enabling gradual feature deployment through system segments with automated split percentage increases.
- Adds system segments that are hidden from regular API operations and skip audit logging
- Implements
PhasedRolloutStatemodel for managing gradual rollout progression - Introduces new pipeline stage action type for phased rollouts with automated split increases
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
api/segments/models.py |
Adds is_system_segment field and audit log skipping logic |
api/segments/views.py |
Filters out system segments from API responses |
api/features/release_pipelines/core/models.py |
Implements PhasedRolloutState model and phased rollout stage action |
api/features/versioning/models.py |
Links feature versions to phased rollout states |
| Various test files | Comprehensive test coverage for new functionality |
| Migration files | Database schema changes for new fields and models |
gagantrivedi
force-pushed
the
feat/5675-phased-rollout
branch
from
August 11, 2025 06:05
7b1d747 to
cab9cdf
Compare
Contributor
Docker builds report
|
Zaimwa9
requested changes
Aug 12, 2025
Zaimwa9
left a comment
Contributor
There was a problem hiding this comment.
Kudos for the thorough test cases.
2 comments:
- To me we have a One-one relationship EFV <> rollout_state no? it would make sense the DB follows
- A default timezone not at the right place
gagantrivedi
force-pushed
the
feat/5675-phased-rollout
branch
from
August 12, 2025 11:12
892355a to
f7a9858
Compare
gagantrivedi
force-pushed
the
feat/5675-phased-rollout
branch
from
August 12, 2025 11:41
4365da4 to
0250809
Compare
Zaimwa9
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Add database models required by release-pipeline-logic to implement phased rollout
How did you test this code?
Covered by unit tests