Skip to content

fix(tests): Improper skip_if_no_analytics_db marker behaviour - #5876

Merged
khvn26 merged 2 commits into
mainfrom
fix/improper-marker
Jul 31, 2025
Merged

fix(tests): Improper skip_if_no_analytics_db marker behaviour#5876
khvn26 merged 2 commits into
mainfrom
fix/improper-marker

Conversation

@khvn26

@khvn26 khvn26 commented Jul 31, 2025

Copy link
Copy Markdown
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This renames the skip_if_no_analytics_db fixture to use_analytics_db and makes sure the markers are initialised in the correct order.

How did you test this code?

Ran the tests with and without the ANALYTICS_DATABASE_URL setting present.

@khvn26
khvn26 requested a review from a team as a code owner July 31, 2025 15:04
@khvn26
khvn26 requested review from matthewelwell and removed request for a team July 31, 2025 15:04
@vercel

vercel Bot commented Jul 31, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2025 3:39pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2025 3:39pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2025 3:39pm

@github-actions github-actions Bot added api Issue related to the REST API fix labels Jul 31, 2025
@github-actions

github-actions Bot commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5876 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5876 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5876 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5876 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5876 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5876 Finished ✅ Results

@github-actions github-actions Bot added fix and removed fix labels Jul 31, 2025
@codecov

codecov Bot commented Jul 31, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.82%. Comparing base (1411f54) to head (04ec8af).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5876   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files        1258     1258           
  Lines       44745    44785   +40     
=======================================
+ Hits        43771    43811   +40     
  Misses        974      974           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khvn26
khvn26 merged commit de61b8b into main Jul 31, 2025
29 checks passed
@khvn26
khvn26 deleted the fix/improper-marker branch July 31, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants