Skip to content

feat: adds dismiss health event - #5863

Merged
khvn26 merged 3 commits into
mainfrom
feat/dismiss-feature-health-notification
Jul 31, 2025
Merged

feat: adds dismiss health event#5863
khvn26 merged 3 commits into
mainfrom
feat/dismiss-feature-health-notification

Conversation

@tiagoapolo

@tiagoapolo tiagoapolo commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

#5844

Screenshot 2025-07-30 at 12 40 12 Screenshot 2025-07-30 at 12 40 08

How did you test this code?

  1. Create a Sample provider
  2. Add unhealthy event for a feature (see payload example below)
  3. Go to feature health tab on feature drawer
  4. See dismiss button and info tooltip
  5. Click on dismiss and event should be dismissed

Payload:

{
  "environment": "Development",
  "status": "unhealthy",
  "feature": "hehe",
  "reason": {
    "text_blocks": [
      {
        "text": "Payment processing service is experiencing 95% error rate",
        "title": "Service Alert"
      },
      {
        "text": "Average response time has increased from 200ms to 2.5s",
        "title": "Performance Degradation"
      },
      {
        "text": "Database connection pool exhausted, causing timeouts",
        "title": "Root Cause"
      }
    ],
    "url_blocks": [
      {
        "url": "https://grafana.company.com/d/abc123/payment-service?orgId=1&from=now-1h&to=now",
        "title": "Grafana Dashboard"
      },
      {
        "url": "https://datadog.company.com/apm/service/payment-service",
        "title": "Datadog APM"
      },
      {
        "url": "https://runbook.company.com/incidents/payment-service-outage",
        "title": "Incident Runbook"
      },
      {
        "url": "https://slack.company.com/archives/C1234567890",
        "title": "Slack Channel"
      },
      {
        "url": "https://jira.company.com/browse/OPS-1234",
        "title": "Jira Ticket"
      }
    ]
  }
}

@tiagoapolo
tiagoapolo requested a review from a team as a code owner July 30, 2025 15:44
@tiagoapolo
tiagoapolo requested review from Zaimwa9 and removed request for a team July 30, 2025 15:44
@vercel

vercel Bot commented Jul 30, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 8:43am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 8:43am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2025 8:43am

@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label Jul 30, 2025
@tiagoapolo tiagoapolo self-assigned this Jul 30, 2025
@tiagoapolo
tiagoapolo requested a review from khvn26 July 30, 2025 15:44
@github-actions github-actions Bot added the feature New feature or request label Jul 30, 2025
@github-actions

github-actions Bot commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5863 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5863 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5863 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5863 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5863 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5863 Finished ✅ Results

khvn26
khvn26 previously approved these changes Jul 31, 2025
Zaimwa9
Zaimwa9 previously approved these changes Jul 31, 2025

@Zaimwa9 Zaimwa9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

Comment thread frontend/web/components/modals/FeatureHealthTabContent.tsx Outdated
@Zaimwa9
Zaimwa9 dismissed stale reviews from khvn26 and themself via e5a6012 July 31, 2025 08:40

@Zaimwa9 Zaimwa9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved after removing comment

@khvn26
khvn26 merged commit 7ef35f9 into main Jul 31, 2025
38 of 39 checks passed
@khvn26
khvn26 deleted the feat/dismiss-feature-health-notification branch July 31, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants