Skip to content

ci(github): Find feature flag references in the code - #5854

Merged
emyller merged 12 commits into
mainfrom
poc/github-code-refs--gha
Aug 1, 2025
Merged

ci(github): Find feature flag references in the code#5854
emyller merged 12 commits into
mainfrom
poc/github-code-refs--gha

Conversation

@emyller

@emyller emyller commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

Closes #5731.

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Introduce CI logic for a PoC to find code references of feature flags in the codebase.

How did you test this code?

See GitHub Actions job run, or the relevant output when the link expires:

Code References:

Feature: announcement
  - frontend/web/components/Announcement.tsx:22
  - frontend/web/components/Announcement.tsx:35

Feature: announcement_per_page
  - frontend/web/components/AnnouncementPerPage.tsx:28
  - frontend/web/components/AnnouncementPerPage.tsx:35

Feature: butter_bar
  - frontend/web/components/ButterBar.tsx:90
  - frontend/web/components/ButterBar.tsx:94

Feature: clone_segment
  - frontend/web/components/segments/SegmentRow/SegmentRow.tsx:45

Feature: context_values
  - frontend/web/components/segments/Rule/components/RuleConditionPropertySelect.tsx:64
  - frontend/web/components/segments/Rule/components/RuleConditionRow.tsx:75

Feature: delighted
  - frontend/web/project/api.ts:148

Feature: disable_create_org
  - frontend/common/utils/utils.tsx:109
  - frontend/web/components/pages/CreateOrganisationPage.js:49

Feature: disable_oauth_registration
  - frontend/web/components/pages/HomePage.tsx:181

Feature: disable_users_as_reviewers
  - frontend/web/components/modals/ChangeRequestModal.tsx:188
  - frontend/web/components/modals/ChangeRequestModal.tsx:194
  - frontend/web/components/modals/ChangeRequestModal.tsx:262
  - frontend/web/components/pages/ChangeRequestDetailPage.js:420

Feature: environment_metrics
  - frontend/web/components/pages/FeaturesPage.js:231

Feature: feature_health
  - frontend/web/components/FeatureRow.tsx:224
  - frontend/web/components/navigation/EnvironmentAside.tsx:56
  - frontend/web/components/navigation/EnvironmentAside.tsx:86
  - frontend/web/components/navigation/EnvironmentAside.tsx:138
  - frontend/web/components/pages/ProjectSettingsPage.js:557
  - frontend/web/components/tables/TableTagFilter.tsx:38
  - frontend/web/components/tags/AddEditTags.tsx:38
  - frontend/web/components/tags/Tag.tsx:73

Feature: feature_versioning
  - frontend/web/components/StaleFlagWarning.tsx:18
  - frontend/web/components/pages/EnvironmentSettingsPage.tsx:558
  - frontend/web/components/pages/ProjectSettingsPage.js:203

Feature: identity_aliases
  - frontend/web/components/pages/UserPage.tsx:281
  - frontend/web/components/pages/UsersPage.tsx:81

Feature: inspect_permissions
  - frontend/web/components/users-permissions/OrganisationUsersTable/components/OrganisationUsersTableRow.tsx:36

Feature: integration_data
  - frontend/common/utils/utils.tsx:364
  - frontend/web/components/IntegrationSelect.tsx:29

Feature: integration_onboarding
  - frontend/web/components/pages/GettingStartedPage.tsx:154

Feature: max_api_calls_alert
  - frontend/web/components/OrganisationLimit.tsx:81

Feature: oauth_github
  - frontend/web/components/pages/HomePage.tsx:199
  - frontend/web/components/pages/HomePage.tsx:206

Feature: oauth_google
  - frontend/web/components/pages/HomePage.tsx:214
  - frontend/web/components/pages/HomePage.tsx:219

Feature: organisation_integrations
  - frontend/web/components/navigation/navbars/OrganisationNavbar.tsx:47

Feature: payments_enabled
  - frontend/web/components/OrganisationLimit.tsx:80
  - frontend/web/components/modals/Payment.js:431
  - frontend/web/components/pages/OrganisationSettingsPage.js:170
  - frontend/web/components/pages/UsersAndPermissionsPage.tsx:82

Feature: project_metrics_tooltip
  - frontend/web/components/navigation/navbars/ProjectNavbar.tsx:24
  - frontend/web/components/navigation/navbars/ProjectNavbar.tsx:77

Feature: read_only_mode
  - frontend/web/components/ButterBar.tsx:91
  - frontend/web/components/ButterBar.tsx:97
  - frontend/web/components/FeatureRow.tsx:223
  - frontend/web/components/pages/FeaturesPage.js:229

Feature: relay_events_key
  - frontend/common/stores/account-store.js:106
  - frontend/common/stores/account-store.js:108

Feature: release_pipelines
  - frontend/web/components/modals/CreateFlag.js:1079
  - frontend/web/components/modals/FlagValueFooter.tsx:45
  - frontend/web/components/navigation/navbars/ProjectNavbar.tsx:93

Feature: restrict_project_create_to_admin
  - frontend/web/components/pages/OrganisationSettingsPage.js:271

Feature: saml
  - frontend/web/components/pages/HomePage.tsx:242
  - frontend/web/components/pages/HomePage.tsx:243

Feature: segment_operators
  - frontend/common/utils/utils.tsx:531

Feature: show_dunning_banner
  - frontend/web/components/ButterBar.tsx:103

Feature: split_testing
  - frontend/web/components/navigation/navbars/EnvironmentNavbar.tsx:108

Feature: sso_idp
  - frontend/web/components/pages/HomePage.tsx:251
  - frontend/web/components/pages/HomePage.tsx:257

Feature: test_webhook_backend
  - frontend/web/components/TestWebhook.tsx:75

Feature: try_it
  - frontend/web/components/TryIt.js:63

Feature: use_identity_overrides_in_local_eval
  - frontend/web/components/pages/EnvironmentSettingsPage.tsx:819

Feature: verify_seats_limit_for_invite_links
  - frontend/common/stores/account-store.js:24
  - frontend/web/components/pages/UsersAndPermissionsPage.tsx:84

Feature: welcome_page
  - frontend/web/components/App.js:193
  - frontend/web/components/navigation/navbars/TopNavbar.tsx:27
  - frontend/web/components/pages/CreateOrganisationPage.js:33

@vercel

vercel Bot commented Jul 30, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2025 10:26pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2025 10:26pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2025 10:26pm

Comment thread .github/workflows/poc-github-code-references.yml Fixed
@emyller emyller changed the title poc/github-code-refs--gha poc(ci): GHA: Find feature flag references in the code Jul 30, 2025
@emyller
emyller force-pushed the poc/github-code-refs--gha branch 2 times, most recently from e514cb7 to 94121ab Compare July 30, 2025 00:12
@emyller emyller changed the title poc(ci): GHA: Find feature flag references in the code feat(ci): GHA: Find feature flag references in the code Jul 30, 2025
@emyller emyller changed the title feat(ci): GHA: Find feature flag references in the code feat(ci): [GHA] Find feature flag references in the code Jul 30, 2025
Comment thread .github/workflows/poc-github-code-references.yml Fixed
@emyller
emyller force-pushed the poc/github-code-refs--gha branch from 94121ab to 94e7aa8 Compare July 30, 2025 00:13
@github-actions github-actions Bot added the feature New feature or request label Jul 30, 2025
@emyller
emyller force-pushed the poc/github-code-refs--gha branch from 94e7aa8 to 6313dc0 Compare July 30, 2025 00:15
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jul 30, 2025
@emyller
emyller force-pushed the poc/github-code-refs--gha branch from 6313dc0 to 2f12cd7 Compare July 30, 2025 00:16
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jul 30, 2025
@codecov

codecov Bot commented Jul 30, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.82%. Comparing base (de61b8b) to head (ec9201c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5854   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files        1258     1258           
  Lines       44785    44785           
=======================================
  Hits        43811    43811           
  Misses        974      974           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emyller
emyller force-pushed the poc/github-code-refs--gha branch from 2f12cd7 to 83ddc54 Compare July 30, 2025 00:31
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jul 30, 2025
@emyller
emyller force-pushed the poc/github-code-refs--gha branch from 83ddc54 to 893cc67 Compare July 30, 2025 00:51
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jul 30, 2025
@emyller
emyller force-pushed the poc/github-code-refs--gha branch from 893cc67 to 824f7dc Compare July 30, 2025 00:56
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jul 30, 2025
@emyller
emyller force-pushed the poc/github-code-refs--gha branch from 824f7dc to fbc08d4 Compare July 30, 2025 01:07
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jul 30, 2025
@github-actions github-actions Bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jul 31, 2025
@emyller
emyller force-pushed the poc/github-code-refs--gha branch from 5ea3415 to 8c6257f Compare July 31, 2025 03:07
@github-actions github-actions Bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jul 31, 2025
@emyller
emyller force-pushed the poc/github-code-refs--gha branch from c8d7a9d to ebbb073 Compare July 31, 2025 15:22
@github-actions github-actions Bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jul 31, 2025
@emyller
emyller force-pushed the poc/github-code-refs--gha branch from ebbb073 to 5999c8d Compare July 31, 2025 15:57
@github-actions github-actions Bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jul 31, 2025
khvn26
khvn26 previously approved these changes Jul 31, 2025

@khvn26 khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d lean toward putting this in a dedicated repo — it would help us start thinking earlier about how the integration should look, and also avoid adding more clutter to the main repo’s .github directory.

Otherwise, the approach looks solid to me, aside from the packaging/integration concerns I flagged in the review comments above.

@github-actions github-actions Bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jul 31, 2025
@github-actions github-actions Bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jul 31, 2025
@khvn26
khvn26 self-requested a review August 1, 2025 16:51
@emyller
emyller merged commit b376502 into main Aug 1, 2025
30 checks passed
@emyller
emyller deleted the poc/github-code-refs--gha branch August 1, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd Build, test and deployment related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build the github action logic to run on a crontab to identify code references for each feature in a given project

3 participants