ci(github): Find feature flag references in the code - #5854
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
emyller
force-pushed
the
poc/github-code-refs--gha
branch
2 times, most recently
from
July 30, 2025 00:12
e514cb7 to
94121ab
Compare
emyller
force-pushed
the
poc/github-code-refs--gha
branch
from
July 30, 2025 00:13
94121ab to
94e7aa8
Compare
emyller
force-pushed
the
poc/github-code-refs--gha
branch
from
July 30, 2025 00:15
94e7aa8 to
6313dc0
Compare
emyller
force-pushed
the
poc/github-code-refs--gha
branch
from
July 30, 2025 00:16
6313dc0 to
2f12cd7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5854 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 1258 1258
Lines 44785 44785
=======================================
Hits 43811 43811
Misses 974 974 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emyller
force-pushed
the
poc/github-code-refs--gha
branch
from
July 30, 2025 00:31
2f12cd7 to
83ddc54
Compare
emyller
force-pushed
the
poc/github-code-refs--gha
branch
from
July 30, 2025 00:51
83ddc54 to
893cc67
Compare
emyller
force-pushed
the
poc/github-code-refs--gha
branch
from
July 30, 2025 00:56
893cc67 to
824f7dc
Compare
emyller
force-pushed
the
poc/github-code-refs--gha
branch
from
July 30, 2025 01:07
824f7dc to
fbc08d4
Compare
emyller
force-pushed
the
poc/github-code-refs--gha
branch
from
July 31, 2025 03:07
5ea3415 to
8c6257f
Compare
emyller
force-pushed
the
poc/github-code-refs--gha
branch
from
July 31, 2025 15:22
c8d7a9d to
ebbb073
Compare
emyller
force-pushed
the
poc/github-code-refs--gha
branch
from
July 31, 2025 15:57
ebbb073 to
5999c8d
Compare
5 tasks
khvn26
previously approved these changes
Jul 31, 2025
khvn26
left a comment
Member
There was a problem hiding this comment.
I’d lean toward putting this in a dedicated repo — it would help us start thinking earlier about how the integration should look, and also avoid adding more clutter to the main repo’s .github directory.
Otherwise, the approach looks solid to me, aside from the packaging/integration concerns I flagged in the review comments above.
khvn26
self-requested a review
August 1, 2025 16:51
khvn26
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5731.
I have added information todocs/if required so people know about the feature!Changes
Introduce CI logic for a PoC to find code references of feature flags in the codebase.
How did you test this code?
See GitHub Actions job run, or the relevant output when the link expires: