Skip to content

feat: disable value and segment change for in-flight feature - #5853

Merged
tiagoapolo merged 2 commits into
mainfrom
feat/disable-feature-value-change
Jul 30, 2025
Merged

feat: disable value and segment change for in-flight feature#5853
tiagoapolo merged 2 commits into
mainfrom
feat/disable-feature-value-change

Conversation

@tiagoapolo

@tiagoapolo tiagoapolo commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

#5811

Screenshot 2025-07-29 at 17 01 17 Screenshot 2025-07-29 at 17 01 13

How did you test this code?

Please describe.

@vercel

vercel Bot commented Jul 29, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2025 8:03pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2025 8:03pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jul 29, 2025 8:03pm

@tiagoapolo
tiagoapolo marked this pull request as ready for review July 29, 2025 20:02
@tiagoapolo
tiagoapolo requested a review from a team as a code owner July 29, 2025 20:03
@tiagoapolo
tiagoapolo requested review from kyle-ssg and removed request for a team July 29, 2025 20:03
@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label Jul 29, 2025
@github-actions

github-actions Bot commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5853 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5853 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5853 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5853 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5853 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5853 Finished ✅ Results

@tiagoapolo tiagoapolo changed the title Feat/disable feature value change feat: disable value and segment change for in-flight feature Jul 29, 2025

@Zaimwa9 Zaimwa9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but we really need to deal with CreateFlag. There are lot of redundancy (out of scope ofc) and deep down I don't think this should be wrapping so much JSX but it's too much refacto otherwise

@tiagoapolo

Copy link
Copy Markdown
Contributor Author

Approving but we really need to deal with CreateFlag. There are lot of redundancy (out of scope ofc) and deep down I don't think this should be wrapping so much JSX but it's too much refacto otherwise

Yes, initially I started doing some refactors but it was too much for a simple task

@tiagoapolo
tiagoapolo merged commit 9f815cd into main Jul 30, 2025
41 of 42 checks passed
@tiagoapolo
tiagoapolo deleted the feat/disable-feature-value-change branch July 30, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants