feat: use dropdown for values with context environment - #5832
Merged
Zaimwa9 merged 14 commits intoAug 11, 2025
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
github-actions
Bot
added
the
front-end
Contributor
Docker builds report
|
…ropdown-for-values-with-context-environment
Zaimwa9
changed the title
khvn26
requested changes
Jul 25, 2025
khvn26
left a comment
khvn26
left a comment
Member
There was a problem hiding this comment.
I see the rationale behind using a dropdown. Consider, however, a case when an environment used in the segment condition was deleted. I believe we should use a searchable dropdown allowing arbitrary values — should work nicely with a warning added by #5805.
Member
|
Closes #5804. |
github-actions
Bot
added
feature
Co-authored-by: Tiago Paiva <tiago@tiagopaiva.me>
github-actions
Bot
added
feature
tiagoapolo
previously approved these changes
Aug 5, 2025
This was referenced Aug 6, 2025
…ropdown-for-values-with-context-environment
…of github.com:Flagsmith/flagsmith into feat/use-dropdown-for-values-with-context-environment
github-actions
Bot
added
feature
tiagoapolo
previously approved these changes
Aug 8, 2025
github-actions
Bot
added
feature
khvn26
approved these changes
Aug 11, 2025
Zaimwa9
deleted the
feat/use-dropdown-for-values-with-context-environment
branch
August 11, 2025 12:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
When using the
Environment namecontext value (and notPERCENTAGE_SPLIT), the input value becomes a dropdown with the project's environment valuesHow did you test this code?
N/A
https://www.loom.com/share/9c00c9440fed4a499ea16192a42cb932?focus_title=1&muted=1&from_recorder=1