Skip to content

feat: Responsive features page - #5809

Merged
kyle-ssg merged 12 commits into
mainfrom
feat/responsive-features-page
Aug 12, 2025
Merged

feat: Responsive features page#5809
kyle-ssg merged 12 commits into
mainfrom
feat/responsive-features-page

Conversation

@kyle-ssg

@kyle-ssg kyle-ssg commented Jul 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

image image
  • Adds better responsiveness to features page
  • Componentises / organises feature summary components
  • Turns inline modals to full screen on mobile

How did you test this code?

@kyle-ssg
kyle-ssg requested a review from a team as a code owner July 22, 2025 16:16
@kyle-ssg
kyle-ssg requested review from Zaimwa9 and removed request for a team July 22, 2025 16:16
@vercel

vercel Bot commented Jul 22, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready Preview Comment Aug 12, 2025 4:04pm
flagsmith-frontend-staging ✅ Ready Preview Comment Aug 12, 2025 4:04pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs ⬜️ Ignored Preview Aug 12, 2025 4:04pm

@kyle-ssg
kyle-ssg marked this pull request as draft July 22, 2025 16:16
@kyle-ssg
kyle-ssg removed the request for review from Zaimwa9 July 22, 2025 16:16
@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Jul 22, 2025
@github-actions

github-actions Bot commented Jul 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5809 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5809 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5809 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5809 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5809 Finished ✅ Results ✅

@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jul 22, 2025
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jul 29, 2025
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jul 29, 2025
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jul 29, 2025
@kyle-ssg
kyle-ssg marked this pull request as ready for review July 29, 2025 14:04
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jul 29, 2025
@kyle-ssg
kyle-ssg marked this pull request as draft July 29, 2025 16:10
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jul 29, 2025
@kyle-ssg
kyle-ssg marked this pull request as ready for review July 30, 2025 08:50
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jul 30, 2025
kyle-ssg added 2 commits August 5, 2025 09:36
@kyle-ssg
Merge branch 'main' into feat/responsive-features-page
eabaa64 
# Conflicts:
#	frontend/web/components/FeatureRow.tsx
@kyle-ssg
Merge main
9a9f144
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 5, 2025
Zaimwa9
Zaimwa9 requested changes Aug 12, 2025
View reviewed changes

@Zaimwa9 Zaimwa9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the restructuring!
Couple of comments. Sorry, due to the long diff I played around and raised what I observed.
Mostly minor (except the modal opening).

Comment thread frontend/web/styles/project/_modals.scss
Comment thread frontend/web/components/modals/CreateFlag.js
Comment thread frontend/web/components/InlineModal.tsx
Comment thread frontend/web/components/feature-summary/FeatureRow.tsx
Comment thread frontend/web/styles/project/_modals.scss
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Aug 12, 2025
Zaimwa9
Zaimwa9 approved these changes Aug 12, 2025
View reviewed changes

@Zaimwa9 Zaimwa9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kyle-ssg
kyle-ssg merged commit 3018bec into main Aug 12, 2025
21 checks passed
@kyle-ssg
kyle-ssg deleted the feat/responsive-features-page branch August 12, 2025 16:05
@flagsmithdev flagsmithdev mentioned this pull request Aug 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zaimwa9 Zaimwa9 Zaimwa9 approved these changes
@tiagoapolo tiagoapolo Awaiting requested review from tiagoapolo

Assignees

No one assigned

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kyle-ssg @Zaimwa9