Conversation
The verify workflow read contextFiles.specs and contextFiles.design, which only exist when the schema names its artifacts "specs" and "design". Find them by artifactPaths.<id>.outputPath instead: spec artifacts are those under specs/, the design artifact is design.md. Closes Fission-AI#2027
Regenerate skills/openspec-verify-change/SKILL.md so the skills.sh copy matches the template, and treat an artifact with id design, or an output path ending in design.md, as the design artifact. Signed-off-by: drakeo338 <paranoyouz@gmail.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Fission-AI/OpenSpec/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughVerify instructions now locate spec and design artifacts through schema output paths and artifact IDs instead of relying only on fixed context-file keys. The templates update verification status when spec files are absent or empty, and when no design artifact is defined. Tests and the patch changeset are updated. ChangesVerify artifact lookup
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to No actionable verification gap is established; the artifact-discovery changes appear ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #2027
What this changes
The verify workflow read
contextFiles.specsandcontextFiles.design, which only exist when a schema names its artifactsspecsanddesign; with other artifact ids it found nothing to verify against. It now finds them throughartifactPaths.<id>.outputPath: spec artifacts are those underspecs/, and the design artifact isdesign.md. The generated skill file is regenerated to match.How you verified it
The updated template tests failed on the previous source (58 passed, 3 failed) and pass with the change (61 passed, 0 failed). I did not run the full build, tsc or lint.
Notes
Written by Claude Code (Claude Sonnet 5.5); I ran the tests above myself.
pnpm changesetif this affects users, and committed the fileSummary by CodeRabbit