Repository navigation
No mask in ESR private window - #97
Conversation
added and exclusion for esr.
|
Thanks, good catch. I checked ESR 153.7's browser.xhtml: there is no One problem with the approach though: the new rules (2,3,1) also outrank the #13 collapse, and #13 is on by default. In an ESR private window the collapsed cluster then keeps the full hamburger + puzzle margin, and on reveal the clearance stays a margin instead of the padding that keeps the hover bridge closed. Customize mode ( Could you flip the existing logic instead of adding rules? Everything that assumes "the mask carries the clearance" should test for the mask, not for private mode. Then an ESR private window behaves exactly like a normal one, #13 padding included:
The |
Exclude esr from the private window mask reserve, it doesn't have one. Upstream PR Firnschnee/FoxOne#97
button padding derived. tab bar reserve worked from button padding. Bookmark bar height derived. Bookmark tool padding is density aware. Vertical tab fill not fixed 10px fixes #45 Vertical tab toolbar is a bigger version of mini window. `--uc-extensions-button-right` set automagicly for mica+ From foxone 4.0.7-9: alt/F10 doesn't break the layout Firnschnee/FoxOne#78 Findbar no longer reacts phantom bookmark bar with "only show on new tabs" set. F11 autohide is tracked by the toolbar. 154+ Firnschnee/FoxOne#94 Floating bookmarks over sidebar panel. Empty AI footer hidden 158+ vertical toolbar ext drawer works to be upstream frinschnee/foxone#96 vert tab toolbar puzzle centred again. ESR private windows don't have a mask upstream pending Firnschnee/FoxOne#97
checked ESR/Nightly Private windows --uc hide extension-icons 1/0 Drawer works as expected in all cases.
|
Thanks, that is cleaner. I've reworked the branch the way you described and pushed it. The two new rules are gone. The zeroing rule and both private reveal-revert rules now require the mask ( Checked in a private window on ESR 153 and Nightly, with Customize mode is still clean. |
|
I keep it simple this time: good job! Thank you! |
The 153 private window doesn't have a mask in the corner? I added an exclusion to that rule for 153 only.