Skip to content

No mask in ESR private window - #97

Merged
Firnschnee merged 3 commits into
Firnschnee:mainfrom
snkiz:ESR-No-Mask
Nov 13, 2026
Merged

Firnschnee merged 3 commits into
Firnschnee:mainfrom
snkiz:ESR-No-Mask

Conversation

@snkiz

@snkiz snkiz commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

The 153 private window doesn't have a mask in the corner? I added an exclusion to that rule for 153 only.

added and exclusion for esr.
@Firnschnee

Copy link
Copy Markdown
Owner

Thanks, good catch. I checked ESR 153.7's browser.xhtml: there is no .private-browsing-indicator-button at all, only the -with-label hbox we already hide. In 160 the button is static markup in every window, so pairing [privatebrowsingmode] with :not(:has(…)) is the right test.

One problem with the approach though: the new rules (2,3,1) also outrank the #13 collapse, and #13 is on by default. In an ESR private window the collapsed cluster then keeps the full hamburger + puzzle margin, and on reveal the clearance stays a margin instead of the padding that keeps the hover bridge closed. Customize mode (:root[customizing]:not([privatebrowsingmode])) and the button-before-cluster rules (:root:not([privatebrowsingmode]) in both #13 blocks) still treat ESR private as "mask present", so they lack clearance as well.

Could you flip the existing logic instead of adding rules? Everything that assumes "the mask carries the clearance" should test for the mask, not for private mode. Then an ESR private window behaves exactly like a normal one, #13 padding included:

  • zeroing rule (~3035) and both private reveal-revert rules (~3119, ~3229):
    :root[privatebrowsingmode] → :root[privatebrowsingmode]:has(#TabsToolbar .private-browsing-indicator-button)
  • customize rule (~3044) and both button-before-cluster rules (~3079, ~3193):
    :not([privatebrowsingmode]) → :where(:not([privatebrowsingmode]), :not(:has(#TabsToolbar .private-browsing-indicator-button)))

The :where() keeps the specificity from climbing, so the reveal rules still beat the button rule. With that in place the two new rules can go. I haven't run this in ESR myself yet, so a quick check with #13 on and off would be great.

snkiz added a commit to snkiz/FoxMica that referenced this pull request Nov 12, 2026
Exclude esr from the private window mask reserve, it doesn't have one.
Upstream PR Firnschnee/FoxOne#97
snkiz added a commit to snkiz/FoxMica that referenced this pull request Nov 12, 2026
button padding derived.
tab bar reserve worked from button padding.
Bookmark bar height derived.
Bookmark tool padding is density  aware.
Vertical tab fill not fixed 10px fixes #45
Vertical tab toolbar is a bigger version of mini window.
`--uc-extensions-button-right` set automagicly for mica+
From foxone 4.0.7-9:
alt/F10 doesn't break the layout Firnschnee/FoxOne#78
Findbar no longer reacts phantom bookmark bar with "only show on new tabs" set.
  F11 autohide is tracked by the toolbar. 154+ Firnschnee/FoxOne#94
Floating bookmarks over sidebar panel.
Empty AI footer hidden 158+
vertical toolbar ext drawer works to be upstream frinschnee/foxone#96
vert tab toolbar puzzle centred again.
ESR private windows don't have a mask upstream pending Firnschnee/FoxOne#97
checked ESR/Nightly Private windows --uc hide extension-icons 1/0
Drawer works as expected in all cases.
@snkiz

snkiz commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, that is cleaner. I've reworked the branch the way you described and pushed it.

The two new rules are gone. The zeroing rule and both private reveal-revert rules now require the mask (:root[privatebrowsingmode]:has(#TabsToolbar .private-browsing-indicator-button)). The customize rule and both button-before-cluster rules wrap the negated selector in :where(), so they also match when the button is absent.

Checked in a private window on ESR 153 and Nightly, with --uc-hide-extension-icons at 1 and at 0 (so with the #13 collapse on and off). It behaves as expected in all four.

Customize mode is still clean.

@Firnschnee
Firnschnee merged commit b3becf9 into Firnschnee:main Nov 13, 2026
1 check passed
Firnschnee added a commit that referenced this pull request Nov 13, 2026
Two-row layouts (FoxMica's StockMica+, PWAsForFirefox windows) rely on --uc-extensions-button-right: 0, so the switch is marked as one to keep (#73). The #13 comment now says only private windows with the mask are left out (#97).
@Firnschnee

Copy link
Copy Markdown
Owner

I keep it simple this time: good job! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants