Skip to content

always a grab area on the vertical toolbar - #100

Merged
Firnschnee merged 1 commit into
Firnschnee:mainfrom
snkiz:98-Vert-Tab-Toolbar-Grab
Nov 13, 2026
Merged

Firnschnee merged 1 commit into
Firnschnee:mainfrom
snkiz:98-Vert-Tab-Toolbar-Grab

Conversation

@snkiz

@snkiz snkiz commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

If there's no flexi space add a flexi margin, like the mini window.

Fixes #98 uses the method described there. I have not seen these three pr's work together. The testing suggests they should work together like the prototype with the changes.

If there's no flexi space add a flexi margin, like the mini window.
@Firnschnee
Firnschnee merged commit 39fc9aa into Firnschnee:main Nov 13, 2026
1 check passed
Firnschnee added a commit that referenced this pull request Nov 13, 2026
Firefox keeps #vertical-spacer as a fixed toolbarspring in every nav bar, and FoxOne hides it through the .titlebar-spacer rule. It still matched :has(> toolbarspring), so the grab-area margin from #100 never applied. Only springs the user placed count now. Both margin rules point at each other so the shared value moves together. (#98)
@Firnschnee

Copy link
Copy Markdown
Owner

Merged, thanks! One follow-up in a8ce1a6: the rule never applied as written. Firefox keeps a fixed <toolbarspring id="vertical-spacer"> in every nav bar (ESR 153 and 160 alike), and FoxOne hides it through the old .titlebar-spacer { display: none } rule. Hidden or not, it still matched :has(> toolbarspring), so the margin always dropped out. That one's on me, it was my selector from the issue.

The fix only counts springs the user placed: :has(> toolbarspring:not(#vertical-spacer)). Tested on 160 with vertical tabs: 96px without a spring, none with one. Both margin rules now point at each other, so the shared value moves together.

Side note: that hidden spacer is Firefox's own grab area for vertical tabs, so FoxOne hiding it is why #98 came up in the first place. I kept our margin on the right instead of bringing the spacer back, since it would sit left of the URL bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vertical tabs: the URL bar can fill the toolbar, so there is nothing left to drag the window by

2 participants