fix(macos): align menu reapply and ChatGPT launch semantics - #342
Open
EchoJamie wants to merge 5 commits into
Open
fix(macos): align menu reapply and ChatGPT launch semantics#342EchoJamie wants to merge 5 commits into
EchoJamie wants to merge 5 commits into
Conversation
added 5 commits
August 5, 2026 15:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
“重新应用皮肤” now attempts hot reapply first without showing a confirmation dialog; only when hot reapply is unavailable does it prompt to open or restart ChatGPT based on the current state.
ChatGPT.app。“打开 ChatGPT” keeps the original menu title, but now uses the Dream Skin launch/apply path instead of only opening the official
ChatGPT.appnatively.Added static regressions that lock the hot-reapply ordering, open/restart confirmation gates, and prevent the “打开 ChatGPT” action from regressing to native app opening.
macos/CHANGELOG.md记录本次用户可见行为修复。Updated
macos/CHANGELOG.mdfor this user-visible behavior fix.Type / 类型
Platform / 平台
Self-check / 自测
Docs-only / 仅文档
macOS (when code under
macos/changes)macos/tests/run-tests.shpassed / 已通过macos/scripts/doctor-macos.shverify-dream-skin-macos.shor Desktop VerifyWindows (when code under
windows/changes)install/start/verify/restorescripts exercised / 已按改动跑过对应脚本User-facing / 用户可见变更
macos/CHANGELOG.md(andmacos/VERSIONif release-worthy) / 已更新 changelog(发版时再 bump VERSION)Security / 安全
127.0.0.1) where applicable / CDP 仍仅本机回环(如适用)Notes / 补充
本地验证已通过:
Local validation passed:
bash -n macos/scripts/apply-from-menubar-macos.shbash -n macos/tests/run-tests.shgit diff --checkswift build --package-path macos/menubar-app --product CodexDreamSkinMenuBarCODEX_DREAM_SKIN_SKIP_DOCTOR=1 bash macos/tests/run-tests.shbash macos/scripts/doctor-macos.shbash macos/scripts/verify-dream-skin-macos.shbash macos/scripts/doctor-macos.sh --require-liveDoctor 已在以下环境通过:macOS 15.5 (24F74)、Apple Silicon、官方
/Applications/ChatGPT.app版本26.730.61639、build6234、Team ID2DC432GLL2、内置 Nodev24.14.0。Doctor passed on macOS 15.5 (24F74), Apple Silicon, official
/Applications/ChatGPT.appversion26.730.61639, build6234, Team ID2DC432GLL2, bundled Nodev24.14.0.Live verify 已通过:端口
9341上的本机回环 CDP 会话可验证,主题noir-mono已应用,首页 L1 结构、侧栏、主区可见,且无 document overflow。Live verify passed: the loopback CDP session on port
9341was verified, themenoir-monowas applied, the home L1 structure, sidebar, and main area were visible, and there was no document overflow.Restore / re-apply smoke 未执行;本轮不勾选该项。
Restore / re-apply smoke was not run; this item is intentionally left unchecked for this PR.
直接运行
swift test --package-path macos/menubar-app在本机受阻,因为当前 Swift 工具链无法导入XCTest;仓库 macOS 测试包装器已识别缺少完整匹配 Xcode 平台并跳过 native XCTest。Direct
swift test --package-path macos/menubar-appis blocked on this host because the current Swift toolchain cannot importXCTest; the repository macOS test wrapper detects the missing full matching Xcode platform and skips native XCTest.本 PR 不修改官方 ChatGPT/Codex App 文件、签名、
app.asar、API Key 或 API Base URL。This PR does not modify official ChatGPT/Codex app files, signatures,
app.asar, API keys, or API Base URL.