feat(theme): add visual sidebar overrides - #323
Draft
RunningCoderLee wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The existing background theme contract could not preserve a complete visual pack when switching themes. Custom navigation and project-folder artwork had to be applied separately, and the pre-v1.5 implementation depended on retired renderer marker classes.
Validation
node --test macos/tests/*.test.mjs windows/tests/*.test.mjs— 76 passedgit diff --check— passedSigned-runtime integrations and Doctor were skipped using the same repository test mode as CI because they require an installed signed app/runtime.
Scope notes
output/are intentionally not included